Bug 499656

Summary:	virt-manager Scaling->Always - scales the guest screen up but not down.
Product:	[Fedora] Fedora	Reporter:	James Laska <jlaska>
Component:	virt-manager	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	11	CC:	berrange, crobinso, erik-fedora, hbrock, jturner, markmc, sassmann, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-12-03 23:55:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	480594

Description James Laska 2009-05-07 15:10:23 UTC

Description of problem:

This may be intentional, but while testing https://fedoraproject.org/wiki/QA:Testcase_Console_Graphics_Scaling it seems that the virt-manager/virt-viewer window correctly scales the guest window when the window size exceeds the guest native resolution.  However when making the guest window smaller, it doesn't scale down with the window size.


Version-Release number of selected component (if applicable):
virt-manager-0.7.0-4.fc11.x86_64

How reproducible:


Steps to Reproduce:
https://fedoraproject.org/wiki/QA:Testcase_Console_Graphics_Scaling
  
Actual results:

virt-manager correctly scales the guest screen up when increasing the window size, but the opposite is not true.  There seems to be a lower bound when scaling down the window.

Expected results:

Free scaling of the window above or below the native resolution of the guest.


Additional info:

Comment 1 Daniel Berrangé 2009-05-07 15:47:40 UTC

Virt-manager needs to call vnc_display_set_force_size(FAlse)  to stop GTK-VNC setting a minimum size on the widget. When doing so though, virt-manager needs to be sure to respond to 'vnc-desktop-resize" signals and set its window to a reasonable initial size, otherwise you'll end up with a 1x1 pixel VNC window by default :-)

Comment 2 Bug Zapper 2009-06-09 15:21:07 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Daniel Berrangé 2009-10-16 14:30:58 UTC

Addressing this bug correctly is quite hard, because there's many scenarios to deal with. The virt-viewer app pretty much does it the right way now

http://hg.fedoraproject.org/hg/virt-viewer/file/e05cd5be9c36/src/viewer.c#l1

 1. Scaling is always enabled
 2. Upon vnc-desktop-resize, the top level window is automatically resized to allow entire VNC desktop to be viewed at 1:1 size if possible
 3. If the VNC desktop won't fit on host desktop at 1:1 size, then top level window is resized as large as possible and the VNC desktop scales to fit what's available
 4. If the user manually resizes the top level window, then no further automatic window resizing will be done - the VNC widget will always scale to the user's requested window size.
 5. The VNC widget is placed inside a GtkAlignment, and this is controlled such that the VNC widget always maintains a normal aspect ratio.

Comment 4 Cole Robinson 2009-11-30 12:08:40 UTC

Okay, taking some inspiration from Dan's virt-viewer code (and vinagre), I've fixed this upstream, but managed to maintain the disabled scaling option and fixed the scrolled window interaction. Moving to POST.

Comment 5 Cole Robinson 2009-12-03 23:55:29 UTC

This would be a bit risky to backport to F11, but it should now be available in rawhide with virt-manager 0.8.1, so closing as RAWHIDE.