Bug 499859

Summary:	Review Request: python-pefile - Python module for working with Portable Executable files
Product:	[Fedora] Fedora	Reporter:	Dave Malcolm <dmalcolm>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-05-11 15:33:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dave Malcolm 2009-05-08 15:43:01 UTC

Spec URL: http://people.redhat.com/dmalcolm/python/python-pefile.spec
SRPM URL: http://people.redhat.com/dmalcolm/python/python-pefile-1.2.10_63-1.src.rpm
Description: 
pefile is a platform-independent Python module for reading and working with
Portable Executable (aka PE) files, most commonly known as .exe and .dll files.

Comment 1 Dave Malcolm 2009-05-08 15:45:08 UTC

*** Bug 499857 has been marked as a duplicate of this bug. ***

Comment 2 Parag AN(पराग) 2009-05-08 17:36:53 UTC

Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1343549
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
dc4d4c8a17ae725791263161b1167b1b6a1fabde  pefile-1.2.10-63.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

Comment 3 Dave Malcolm 2009-05-08 17:49:12 UTC

Thanks; requesting CVS

New Package CVS Request
=======================
Package Name: python-pefile
Short Description: Python module for working with Portable Executable files
Owners: dmalcolm
Branches: EL-5
InitialCC:

Comment 4 Kevin Fenzi 2009-05-09 21:12:04 UTC

cvs done.

Comment 5 Dave Malcolm 2009-05-11 15:33:59 UTC

I've imported the spec into CVS ("devel" and "EL-5") and built the package into each of these (dist-f12 and EPEL5).

Closing this review as NEXTRELEASE - thanks everyone!