Spec URL: http://people.redhat.com/dmalcolm/python/python-pefile.spec SRPM URL: http://people.redhat.com/dmalcolm/python/python-pefile-1.2.10_63-1.src.rpm Description: pefile is a platform-independent Python module for reading and working with Portable Executable (aka PE) files, most commonly known as .exe and .dll files.
*** Bug 499857 has been marked as a duplicate of this bug. ***
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1343549 + rpmlint is silent for SRPM and for RPM. + source files match upstream url dc4d4c8a17ae725791263161b1167b1b6a1fabde pefile-1.2.10-63.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. APPROVED.
Thanks; requesting CVS New Package CVS Request ======================= Package Name: python-pefile Short Description: Python module for working with Portable Executable files Owners: dmalcolm Branches: EL-5 InitialCC:
cvs done.
I've imported the spec into CVS ("devel" and "EL-5") and built the package into each of these (dist-f12 and EPEL5). Closing this review as NEXTRELEASE - thanks everyone!