Bug 500506 (389-adminutil)
Summary: | Review Request: 389-adminutil - renamed from adminutil | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rich Megginson <rmeggins> |
Component: | Package Review | Assignee: | Dennis Gilmore <dennis> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, felix, mastahnke, notting, shaines |
Target Milestone: | --- | Flags: | dennis:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-17 21:15:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 500746, 501393 |
Description
Rich Megginson
2009-05-12 22:49:05 UTC
rpmlint is pretty verbose on this: [felix@polaris result]$ rpmlint *.rpm 389-adminutil 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadminutil.so.1.1.8 exit.5 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadmsslutil.so.1.1.8 exit.5 389-adminutil-devel.x86_64: W: no-documentation 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadminutil.so.1.1.8 exit.5 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /lib64/libssl3.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /lib64/libnss3.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /usr/lib64/libssldap60.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /usr/lib64/libprldap60.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /usr/lib64/libldif60.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /usr/lib64/libicui18n.so.40 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadminutil.so.1.1.8 /usr/lib64/libicudata.so.40 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadmsslutil.so.1.1.8 exit.5 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadmsslutil.so.1.1.8 /usr/lib64/libprldap60.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadmsslutil.so.1.1.8 /usr/lib64/libldif60.so 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadmsslutil.so.1.1.8 /usr/lib64/libicui18n.so.40 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadmsslutil.so.1.1.8 /usr/lib64/libicuuc.so.40 389-adminutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libadmsslutil.so.1.1.8 /usr/lib64/libicudata.so.40 5 packages and 0 specfiles checked; 0 errors, 17 warnings. Updated Source URL: http://port389.org/sources/389-adminutil-1.1.8.tar.bz2 md5sum 389-adminutil-1.1.8.tar.bz2 e84240547e2f7b97d0576bcb85c06a57 389-adminutil-1.1.8.tar.bz2 sha1sum 389-adminutil-1.1.8.tar.bz2 17581245a0d95b3f7cda90c3ed83b7984afe9b2c 389-adminutil-1.1.8.tar.bz2 I would like to waive or otherwise accept the rpmlint results. This is the output I get from rpmlint - same results with both rpmlint 0.85 and 0.87 on Fedora 10 389-adminutil.i386: W: shared-lib-calls-exit /usr/lib/libadmsslutil.so.1.1.8 exit 389-adminutil.i386: W: shared-lib-calls-exit /usr/lib/libadminutil.so.1.1.8 exit This is ok - these are functions specifically for handling fatal errors on behalf of the calling application. 389-adminutil-devel.i386: W: no-documentation The devel package has no documentation - it's all in the base package rpmlint -v /var/lib/mock/fedora-10-i386/result/389-adminutil-1.1.8-2.fc10.src.rpm 389-adminutil.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. I'm not sure where the other errors are coming from. I do know that libadminutil does not strictly need to link directly against ssl, nss, ssldap60, or ldif60 - but all applications that want to support SSL (which is all of them) will need to also link with libadmsslutil which does require the SSL libs. ldif60 is not strictly needed but it doesn't hurt to link with it. The ICU dependencies are required to link with ICU even though rpmlint says they are not needed. Any takers? What can I do to help this along? ping This package is used by 389-admin and 389-dsgw - even though those packages are approved, this one is not, and so will definitely complicate matters. What can I do to speed up the review for this package? I will not be able to release the 389 suite without this package. ping Who are you pinging? Nobody is assigned to review this ticket. Moved Spec URL: http://rmeggins.fedorapeople.org/pkgreview/389-adminutil.spec SRPM URL: http://rmeggins.fedorapeople.org/pkgreview/389-adminutil-1.1.8-2.src.rpm Source URL: http://port389.org/sources/389-adminutil-1.1.8.tar.bz2 rpmlint is quiet sha256sums of upstream tarball and whats in the srpm match e442f7d538258d7b3cbd88d1fcfa0ad28e0716a8d8428efaa7b9af58c99d6529 389-ds-console-1.2.0.tar.bz2 e442f7d538258d7b3cbd88d1fcfa0ad28e0716a8d8428efaa7b9af58c99d6529 /home/dennis//fedora/SOURCES/389-ds-console-1.2.0.tar.bz2 obsoletes/provides is sane and replaces the old version Approved. New Package CVS Request ======================= Package Name: 389-adminutil Short Description: Utility library for 389 administration Owners: rmeggins nkinder nhosoi Branches: F-10 F-11 rpmlint is not quiet but i think its ok. it would be good to get the exit calls removed from the shared libraries 389-adminutil-devel.x86_64: W: no-documentation 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadminutil.so.1.1.8 exit.5 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadmsslutil.so.1.1.8 exit.5 4 packages and 0 specfiles checked; 0 errors, 3 warnings. sha256sum matches upstream f5872d644971f51e45d402d3a913d2b0b1c4575122fb849bde5048fecd9f6872 389-adminutil-1.1.8.tar.bz2 f5872d644971f51e45d402d3a913d2b0b1c4575122fb849bde5048fecd9f6872 /home/dennis//fedora/SOURCES/389-adminutil-1.1.8.tar.bz2 obsoletes/provides is sane and makes sure that the old version are removed. builds fine in mock approved sorry pasted the 389-ds-console review in here CVS Done cvs import done - built in koji - all branches imported New Package CVS Request ======================= Package Name: 389-adminutil Short Description: Utility library for 389 administration Owners: stahnma Branches: EL4, EL5 cvs done. Package Change Request ====================== Package Name: 389-adminutil New Branches: epel7 Owners: mreynolds nhosoi nkinder rmeggins Git done (by process-git-requests). |