Bug 501098 (perl-XML-RSS-LibXML)

Summary: Review Request: perl-XML-RSS-LibXML - XML::RSS with XML::LibXML
Product: [Fedora] Fedora Reporter: Iain Arnell <iarnell>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/XML-RSS-LibXML/
Whiteboard:
Fixed In Version: 0.3004-1.fc10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-19 04:40:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Iain Arnell 2009-05-16 06:26:07 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-XML-RSS-LibXML.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-XML-RSS-LibXML-0.3004-1.fc12.src.rpm

Description:
XML::RSS::LibXML uses XML::LibXML (libxml2) for parsing RSS instead of
XML::RSS' XML::Parser (expat), while trying to keep interface compatibility
with XML::RSS.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1357637

*rt-0.09

Comment 1 Parag AN(पराग) 2009-05-18 04:33:25 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1357637
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a44ad501b84d1fd31c4d77e80fdd927f67ebc5aa  XML-RSS-LibXML-0.3004.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=34, Tests=701,  8 wallclock secs ( 0.06 usr  0.05 sys +  7.53 cusr  0.62 csys =  8.26 CPU)
+ Package perl-XML-RSS-LibXML-0.3004-1.fc12.noarch  =>
Provides: perl(XML::RSS::LibXML) = 0.3004 perl(XML::RSS::LibXML::ImplBase) perl(XML::RSS::LibXML::MagicElement) = 0.02 perl(XML::RSS::LibXML::Namespaces) perl(XML::RSS::LibXML::Null) perl(XML::RSS::LibXML::V0_9) perl(XML::RSS::LibXML::V0_91) perl(XML::RSS::LibXML::V1_0) perl(XML::RSS::LibXML::V2_0)
Requires: perl(Carp) perl(DateTime::Format::Mail) perl(DateTime::Format::W3CDTF) perl(UNIVERSAL::require) perl(XML::LibXML) perl(XML::LibXML::XPathContext) perl(XML::RSS::LibXML::MagicElement) perl(XML::RSS::LibXML::Namespaces) perl(base) perl(overload) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

APPROVED.

Comment 2 Iain Arnell 2009-05-18 16:20:17 UTC
New Package CVS Request
=======================
Package Name: perl-XML-RSS-LibXML
Short Description: XML::RSS with XML::LibXML
Owners: iarnell
Branches: F-10 F-11
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-05-18 23:45:50 UTC
cvs done.

Comment 4 Fedora Update System 2009-05-19 04:17:58 UTC
perl-XML-RSS-LibXML-0.3004-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-XML-RSS-LibXML-0.3004-1.fc11

Comment 5 Fedora Update System 2009-05-19 04:18:04 UTC
perl-XML-RSS-LibXML-0.3004-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-XML-RSS-LibXML-0.3004-1.fc10

Comment 6 Iain Arnell 2009-05-19 04:40:21 UTC
Thanks for the review! :-)

Comment 7 Fedora Update System 2009-05-27 19:03:43 UTC
perl-XML-RSS-LibXML-0.3004-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-05-27 19:08:12 UTC
perl-XML-RSS-LibXML-0.3004-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.