Spec URL: http://fedorapeople.org/~iarnell/review/perl-XML-RSS-LibXML.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-XML-RSS-LibXML-0.3004-1.fc12.src.rpm Description: XML::RSS::LibXML uses XML::LibXML (libxml2) for parsing RSS instead of XML::RSS' XML::Parser (expat), while trying to keep interface compatibility with XML::RSS. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1357637 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1357637 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a44ad501b84d1fd31c4d77e80fdd927f67ebc5aa XML-RSS-LibXML-0.3004.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=34, Tests=701, 8 wallclock secs ( 0.06 usr 0.05 sys + 7.53 cusr 0.62 csys = 8.26 CPU) + Package perl-XML-RSS-LibXML-0.3004-1.fc12.noarch => Provides: perl(XML::RSS::LibXML) = 0.3004 perl(XML::RSS::LibXML::ImplBase) perl(XML::RSS::LibXML::MagicElement) = 0.02 perl(XML::RSS::LibXML::Namespaces) perl(XML::RSS::LibXML::Null) perl(XML::RSS::LibXML::V0_9) perl(XML::RSS::LibXML::V0_91) perl(XML::RSS::LibXML::V1_0) perl(XML::RSS::LibXML::V2_0) Requires: perl(Carp) perl(DateTime::Format::Mail) perl(DateTime::Format::W3CDTF) perl(UNIVERSAL::require) perl(XML::LibXML) perl(XML::LibXML::XPathContext) perl(XML::RSS::LibXML::MagicElement) perl(XML::RSS::LibXML::Namespaces) perl(base) perl(overload) perl(strict) perl(vars) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-XML-RSS-LibXML Short Description: XML::RSS with XML::LibXML Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-XML-RSS-LibXML-0.3004-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-XML-RSS-LibXML-0.3004-1.fc11
perl-XML-RSS-LibXML-0.3004-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-XML-RSS-LibXML-0.3004-1.fc10
Thanks for the review! :-)
perl-XML-RSS-LibXML-0.3004-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-XML-RSS-LibXML-0.3004-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.