Bug 501383 (389-ds-console)
| Summary: | Review Request: 389-ds-console - 389 Directory Server Management Console | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rich Megginson <rmeggins> |
| Component: | Package Review | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, notting, shaines |
| Target Milestone: | --- | Flags: | dennis:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-17 21:19:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rich Megginson
2009-05-18 20:52:42 UTC
Any takers? What can I do to help this along? ping What can I do to speed up the package review process? I will not be able to release the 389 directory server suite without this package. ping To anticipate similar comments made for review https://bugzilla.redhat.com/show_bug.cgi?id=389-admin-console Checked the copyrights - looks like the source files were already correctly GPLv2 licensed (not GPLv2+ as the admin console files were). > - Why you put the jar files into %{_datadir}/dirsrv/manual/html/java? The way the console works is that it dynamically downloads (and caches) the jar file corresponding to the server version you are managing. This allows you to use the console to manage older and compatible newer versions of directory server and admin server. The location %{_datadir}/dirsrv/manual/html/java is where the admin server looks for the jar files when a request is made to download them to the console machine. The files under %{_datadir}/dirsrv/manual/html/java are not used directly - they are downloaded to $HOME/.fedora-idm-console (or now $HOME/.389-console) where they are loaded into the console. > - Because the manual seems to be very large, a separate doc > subpackage make sense Done. Spec: http://rmeggins.fedorapeople.org/pkgreview/389-ds-console.spec SRPM: http://rmeggins.fedorapeople.org/pkgreview/389-ds-console-1.2.0-3.src.rpm rpmlint is not quiet but i think its ok. it would be good to get the exit calls removed from the shared libraries 389-adminutil-devel.x86_64: W: no-documentation 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadminutil.so.1.1.8 exit.5 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadmsslutil.so.1.1.8 exit.5 4 packages and 0 specfiles checked; 0 errors, 3 warnings. sha256sum matches upstream f5872d644971f51e45d402d3a913d2b0b1c4575122fb849bde5048fecd9f6872 389-adminutil-1.1.8.tar.bz2 f5872d644971f51e45d402d3a913d2b0b1c4575122fb849bde5048fecd9f6872 /home/dennis//fedora/SOURCES/389-adminutil-1.1.8.tar.bz2 obsoletes/provides is sane and makes sure that the old version are removed. approved > rpmlint is not quiet but i think its ok. it would be good to get the exit
> calls removed from the shared libraries
>
> 389-adminutil-devel.x86_64: W: no-documentation
> 389-adminutil.x86_64: W: shared-lib-calls-exit /usr/lib64/libadminutil.so.1.1.8
> exit.5
> 389-adminutil.x86_64: W: shared-lib-calls-exit
> /usr/lib64/libadmsslutil.so.1.1.8 exit.5
> 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
> sha256sum matches upstream
> f5872d644971f51e45d402d3a913d2b0b1c4575122fb849bde5048fecd9f6872
> 389-adminutil-1.1.8.tar.bz2
> f5872d644971f51e45d402d3a913d2b0b1c4575122fb849bde5048fecd9f6872
> /home/dennis//fedora/SOURCES/389-adminutil-1.1.8.tar.bz2
>
> obsoletes/provides is sane and makes sure that the old version are removed.
>
>
> approved
wrong package? This is 389-ds-console not 389-adminutil
rpmlint is quiet sha256sums of upstream tarball and whats in the srpm match e442f7d538258d7b3cbd88d1fcfa0ad28e0716a8d8428efaa7b9af58c99d6529 389-ds-console-1.2.0.tar.bz2 e442f7d538258d7b3cbd88d1fcfa0ad28e0716a8d8428efaa7b9af58c99d6529 /home/dennis//fedora/SOURCES/389-ds-console-1.2.0.tar.bz2 obsoletes/provides is sane and replaces the old version Builds fine in mock Approved. bad copy and paste. New Package CVS Request ======================= Package Name: 389-ds-console Short Description: 389 Directory Server Management Console Owners: rmeggins nhosoi nkinder Branches: F-10 F-11 CVS Done cvs import done - built in koji - all branches imported New Package CVS Request ======================= Package Name: 389-ds-console Short Description: 389 Directory Server Management Console Owners: stahnma Branches: EL4, EL5 cvs done. Package Change Request ====================== Package Name: 389-ds-console New Branches: epel7 Owners: mreynolds nhosoi nkinder rmeggins Git done (by process-git-requests). |