Bug 501757
Summary: | Loader no longer shows the mac address during "Networking Device" selection | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | James Laska <jlaska> |
Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | anaconda-maint-list, dcantrell, jason310, jturner, notting, rezwanul_kabir, rmaximo, vanmeeuwen+fedora |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-05-29 14:17:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 446452 |
Description
James Laska
2009-05-20 15:44:32 UTC
I can reproduce this at will in rawhide. I replace loader on the initrd with a locally built one (no code changes) and it works. Uh oh, that smacks of environmental differences. Was your local built loader done in a minimal chroot, or just on your regular install file system? I'm wondering if we need some tool brought along that we aren't getting in the chroot? Switching to RPM_OPT_FLAGS for CFLAGS makes it reproducible. Patch posted, although it's really not obvious to me why this would fail now. Bill Nottingham, There's an off-by-one error at your link: http://git.fedorahosted.org/git/?p=anaconda.git;a=commitdiff;h=e8a00c3a91072e9d00b877f70266735375b9bdbf Filling the buffer with 64 nulls, then reading in (up to) 64 bytes, could overwrite all the nulls. This code needs to either: 1) use the return value of read() instead of strlen() 2) make the buffer (and memset()) one byte bigger (65 bytes) or 3) try reading only 63 bytes. Take care, - Jason In practice, the sysfs files are never that long. But defensive programming, etc., yes. No longer observing this failure as of anaconda-11.5.0.56. This will be fixed in F11. Thanks! *** Bug 517123 has been marked as a duplicate of this bug. *** |