Bug 501960 (webinject)
Summary: | Review Request: webinject - Web/HTTP Test Tool | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Hannequin <david.hannequin> |
Component: | Package Review | Assignee: | Jan Klepek <jan.klepek> |
Status: | CLOSED CANTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, jan.klepek, notting, pahan, rebus |
Target Milestone: | --- | Flags: | jan.klepek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-04-17 21:44:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 501251, 501957 | ||
Bug Blocks: | 563471 |
Description
David Hannequin
2009-05-21 13:22:49 UTC
Below links to new spec and srpm files : Spec URL: http://hvad.cfppa-cibeins.com/webinject/webinject.spec SRPM URL: http://hvad.cfppa-cibeins.com/webinject/webinject-1.41-2.fc10.src.rpm 1] Source should be URL-like http://fedoraproject.org/wiki/Packaging/SourceURL 2] Summary would be nicer like "web/http testing tool" 3] no desktop file present http://fedoraproject.org/wiki/Packaging/Guidelines#desktop 4] files duplicated http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles 5] why to have all files with 0755 permissions? http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions 6] this application looks for me like dead, the latest version is from Jan 4, 2006. Hi, I take into account your remarks and I put a new spec file. Thanks ping? Hi, 1] I fixed URL source. 2] I fixed summary. 3] desktop file don't work, i must read more seriously documentation (WIP). 4] I don't see duplicated file. 5] I put two files with the rights in 0755 to be executable by everyone. 6] I use this software to routinely test the web sites and in the case of an abandonment of the application by the author I would development. Spec URL: http://hvad.cfppa-cibeins.com/webinject/webinject.spec SRPM URL: http://hvad.cfppa-cibeins.com/webinject/webinject-1.41-3.fc10.src.rpm Sorry for the delay. Hi, I fixed desktop file. Spec URL: http://hvad.cfppa-cibeins.com/webinject/webinject.spec SRPM URL: http://hvad.cfppa-cibeins.com/webinject/webinject-1.41-4.fc10.src.rpm Best regard (In reply to comment #2) > 6] this application looks for me like dead, the latest version is from Jan 4, > 2006. - This my point is not valid anymore as I'm now co-developer of this project :) - Gui package is wrongly created put there only files related to gui (desktop file, webinjectgui.pl and other gui-only related files) and require webinject package. - would you consider adding this patch to this package and applying it during %prep section? http://hpejakle.fedorapeople.org/packages/bugfix.patch this is bug fix for following issues: https://sourceforge.net/tracker/?func=detail&aid=2807516&group_id=100145&atid=1131923 https://sourceforge.net/tracker/?func=detail&aid=2807516&group_id=100145&atid=1131923 - if you would like, i could co-maintain this fedora package. (In reply to comment #7) Hi, > > 6] this application looks for me like dead, the latest version is from Jan 4, > > 2006. > - This my point is not valid anymore as I'm now co-developer of this project :) Great :-). > - Gui package is wrongly created > put there only files related to gui (desktop file, webinjectgui.pl and other > gui-only related files) and require webinject package. I added require webinject in webinject-gui because webinject-gui need webinject.pl. > - would you consider adding this patch to this package and applying it during > %prep section? > http://hpejakle.fedorapeople.org/packages/bugfix.patch > > this is bug fix for following issues: > https://sourceforge.net/tracker/?func=detail&aid=2807516&group_id=100145&atid=1131923 > https://sourceforge.net/tracker/?func=detail&aid=2807516&group_id=100145&atid=1131923 I try to apply your patch. > - if you would like, i could co-maintain this fedora package. Hum, i try to do by myself but if i'm having trouble i will seek. Thank Hi, I fix webinjectgui. New spec file and srpm : Spec URL: http://hvad.cfppa-cibeins.com/webinject/webinject.spec SRPM URL: http://hvad.cfppa-cibeins.com/webinject/webinject-1.41-5.fc10.src.rpm Best regard 1] sed -i 's|./webinject.pl|/usr/share/webinject.pl|g' %{buildroot}%{_datadir}/%{name}/webinjectgui.pl -> why? both (webinject and webinject-gui) will be in same directory. 2] useless comments Hi, 1] If the file path is not complete the GUI does not work. I added your patch in new srpm. Spec URL: http://hvad.cfppa-cibeins.com/webinject/webinject.spec SRPM URL: http://hvad.cfppa-cibeins.com/webinject/webinject-1.41-6.fc10.src.rpm Best regard ps : sorry but i do not speak English fluently. your sed is invalid there will be never /usr/share/webinject.pl I fix wrong sed : sed -i 's|./webinject.pl|/usr/share/webinject/webinject.pl|g' %{buildroot}%{_datadir}/%{name}/webinjectgui.pl seems fine, however i will give final approval when dependencies are pushed as I want to test it before (even when it is not in "must") 1] ah, just found out, could you please link do symlink from %{_bindir}/webinject to %{_datadir}/%{name}/webinject.pl that if user type "webinject" into command line that it will start the webinject? 2] desktop file i disagree that this type of application should be in Graphics category Categories=Graphics; Hello, I added the symlink but you can specify in which category should be applied? Best regard Applications/Internet would be better Hello, The new spec file and SRPM are the url below : Spec URL: http://hvad.fedorapeople.org/fedora/webinject/webinject.spec SRPM URL: http://hvad.fedorapeople.org/fedora/webinject/webinject-1.41-8.fc10.src.rpm Best regard (In reply to comment #15) > 2] desktop file > i disagree that this type of application should be in Graphics category > Categories=Graphics; This is still not changed to correct category in desktop file. Hello, The new spec file and SRPM are the url below : Spec URL: http://hvad.fedorapeople.org/fedora/webinject/webinject.spec SRPM URL: http://hvad.fedorapeople.org/fedora/webinject/webinject-1.41-9.fc10.src.rpm Best regard (In reply to comment #20) Hello, I make a mistake in stating the URL of the SRPM. URL are correct : Spec URL: http://hvad.fedorapeople.org/fedora/webinject/webinject.spec SRPM URL: http://hvad.fedorapeople.org/fedora/webinject/webinject-1.41-9.fc12.src.rpm Best regard still same issue, when I open src.rpm, in desktop file I still see Categories=Graphics; please fix it Hi, It's fix. Spec URL: http://hvad.fedorapeople.org/fedora/webinject/webinject.spec SRPM URL: http://hvad.fedorapeople.org/fedora/webinject/webinject-1.41-10.fc12.src.rpm Best regard ln should be during %install (sorry that I missed it in #c18) and it have to be relative symlink (please use rpmlint command to check before you provide new version) David, ping? Jan, Sorry for the late reply. I try to find the correct way to have the perl script in %{_bindir}. As soon as I find I post the new file. Hi, My new spec file and srpm : Spec URL: http://hvad.fedorapeople.org/fedora/webinject/webinject.spec SRPM URL: http://hvad.fedorapeople.org/fedora/webinject/webinject-1.41-11.fc13.src.rpm Best regard Sorry for late... Hello David, it seems there is some permission problem on the files referenced. Please could you check that it is possible to download those? Thank you Michal Ambroz Hi Michael, I fix it. Best regard approved if you want, you could specify me as co-maintainer Ping David? Are you still interested in the webinject package? I am looking forward to see it in Fedora. Mik perl module replaces the software webinject. See http://search.cpan.org/~nierlein/Webinject-1.66/lib/Webinject.pm |