Spec URL: http://hvad.cfppa-cibeins.com/perl-Tk-Stderr/perl-Tk-Stderr.spec SRPM URL: http://hvad.cfppa-cibeins.com/perl-Tk-Stderr/perl-Tk-Stderr-1.2-2.fc10.src.rpm Description: This module captures that standard error of a program and redirects it to a read only text widget, which doesn't appear until necessary. When it does appear, the user can close it; it'll appear again when there is more output.
Good: + Basename of the SPEC files matches with package name. + Package name fullfill the naming guidelines. + URL shows on proper project home page + Package contains most recent release of the application + Could download upstream sources via spectool -g + Package tar ball matches which upstream sources (md5sum: 86f0f85d24d2c1e72e1e5a039b0f0d72) + Package contains proper license tag + License tag contains GPLv2 as a valid OSS license + Package has proper Buildroot defintion + BuildRoot will be clean on start of %clean and %install + Package is BuiildArch noarch + Package has not subpackages + Package contains a %check stanza + Local build works fine + Rpmlint is quiete on source rpm + rpmlint is quiete on binary rpm + Local install and uninstall works fine + %doc stanza is small, so we don't need extra doc subpackage + %files stanza has proper %defattr definition + Files have proper files permissions + All package files are owned by the package + No packaged file is owned by another package + Package has proper Changelog Bad: - BR perl is not requires, because perl(Tk) requires perl - Package doesn't contains verbatin copy of the license text - Source files doesn't contains copyright notes - README says package should have the same license as perl Perl is GPLV2 and Artistic. Please clarify license with upstream. - Koji build fails. Please see http://koji.fedoraproject.org/koji/taskinfo?taskID=1361022 I assume, that we have to deactivate the %check stanza
Hello, I fix build require and i sent an email to the author of the module to seek clarification on the license. I have read http://koji.fedoraproject.org/koji/taskinfo?taskID=1361022 but don't understand. Best regard
(In reply to comment #2) > Hello, > > I fix build require and i sent an email to the author of the module to seek > clarification on the license. OK, Please upload a new release for review. > I have read http://koji.fedoraproject.org/koji/taskinfo?taskID=1361022 > but don't understand. The issue is, that the 'make chech' command in the %check stanza need a running X-Server. Unfortunately on a build server we don't have a GUI.To selve this issue it may be nice, if you remove the %check stanza completely.
Sorry i have read build.log and it need X screen. Spec URL: http://hvad.cfppa-cibeins.com/perl-Tk-Stderr/perl-Tk-Stderr.spec SRPM URL: http://hvad.cfppa-cibeins.com/perl-Tk-Stderr/perl-Tk-Stderr-1.2-4.fc10.src.rpm Best regard
Ok, the package could build on koji, so I can APPROVE it. But it may be nice, if you can clarify the license state with the upstream.
Hi, I sent an email to the upstream to specify the license. For the moment I did not answer. Below links to new spec and srpm files : Spec URL: http://hvad.cfppa-cibeins.com/perl-Tk-Stderr/perl-Tk-Stderr.spec SRPM URL: http://hvad.cfppa-cibeins.com/perl-Tk-Stderr/perl-Tk-Stderr-1.2-5.fc10.src.rpm Best regard
Because I have APPROVED you package, it may be nice, if you can create a CVSAdmin Request.
New Package CVS Request ======================= Package Name: perl-Tk-Stderr Short Description: This module captures that standard error of a program and redirects it to a read only text widget. Owners: hvad Branches: F-10 F-11 InitialCC: hvad
Hi, My FAS login is hvad but i can't change fedora-cvs flag to ?. Best regard
Before request CVS administration against your package you need to be an approved packager member in order to proceed (as FAS said you're not currently). You will need to find a sponsor first.
I can overtake this part. Please create a membership request for the packager group on FAS, so I can sponsor you.
Thanks Jochen to taking care of this as i don't even followed this review, i can go ahead on sponsorship. David, Please follow this step below in order to let Jochen sponsor you. https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
@David: I have sponsor your, so you can create a CVSAdmin request.
CVS done. I uses a shorter short description.
Where are the updates in bodhi?
David, you might miss some packaging steps. Here's how to request a push into FPC repositories: => https://fedoraproject.org/wiki/Package_update_HOWTO#Submit_your_update_to_Bodhi
i done updates in bodhi.
david, did you put bug # in update request? if not, please close this manually