Bug 502851
| Summary: | Review Request: pokerth - A Texas-Holdem poker game | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, palango |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.7-5.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-16 16:44:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Susi Lehtola
2009-05-27 13:56:32 UTC
Note: I can't get this to build on F10 due to missing /usr/include/boost/asio.hpp, in F11 it builds fine, though. Will review shortly. Instead I would appreciate it if you review either of my review requests (bug 504707, bug 504709 or bug 505406). Some notes:
* Fonts symlink
-------------------------------------------------------------------
ln -s %{_datadir}/fonts/bistream-vera/VeraBd.ttf %{buildroot}%{_datadir}/%{name}/data/fonts/
-------------------------------------------------------------------
- This is /bi"t"stream-vera/
( does this mean that this file is actually not needed? )
* Timestamps
-------------------------------------------------------------------
359 make -f Makefile.pokerth_game install
360 make[1]: Entering directory `/builddir/build/BUILD/PokerTH-0.7-src'
361 install -m 644 -p /builddir/build/BUILD/PokerTH-0.7-src/data/data-copyright.txt /builddir/build/BUILDROOT/pokerth-0.7-1.fc12.i386/usr/share/pokerth/data/
362 cp -f -r /builddir/build/BUILD/PokerTH-0.7-src/data/fonts /builddir/build/BUILDROOT/pokerth-0.7-1.fc12.i386/usr/share/pokerth/data/
-------------------------------------------------------------------
- make install INSTALL_ROOT=%{buildroot} COPY="cp -p -f" is preferred
to keep timestamps on installed files.
Fixed symlink and timestamp issue. http://theory.physics.helsinki.fi/~jzlehtol/rpms/pokerth.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/pokerth-0.7-2.fc11.src.rpm Would you explain why you added "BR: asio-devel"? boost::asio is defined in the header files in boost-devel. By the way would you have a time to review my review requests? If not I will ask someone else. (In reply to comment #5) > Would you explain why you added "BR: asio-devel"? > boost::asio is defined in the header files in boost-devel. Oh, that was part of debugging why I couldn't get it to compile on F10. Didn't help, removed. > By the way would you have a time to review my review requests? > If not I will ask someone else. To tell the truth I'm a bit swamped at the moment with 35 open reviews, but if I get time I will have a look at them. IIRC I haven't done any ruby gem reviews so far. If new boost is needed to compile this package, you can write explicitly: BR: boost-devel >= 1.37 to show that this won't build on F-10. ----------------------------------------------------------- This package (pokerth) is APPROVED by mtasaka ----------------------------------------------------------- I versioned the BR, thanks a lot for the review! New Package CVS Request ======================= Package Name: pokerth Short Description: A Texas-Holdem poker game Owners: jussilehtola Branches: F-11 InitialCC: cvs done. pokerth-0.7-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pokerth-0.7-3.fc11 Now closing. pokerth-0.7-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pokerth-0.7-5.fc11 pokerth-0.7-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |