Red Hat Bugzilla – Bug 505406
Review Request: rubygem-rake-compiler - Rake-based Ruby C Extension task generator
Last modified: 2014-09-21 14:43:32 EDT
Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-rake-compiler/rubygem-rake-compiler.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-rake-compiler/rubygem-rake-compiler-0.5.0-1.fc.src.rpm Description: rake-compiler aims to help Gem developers while dealing with Ruby C extensions, simplifiying the code and reducing the duplication. It follows *convention over configuration* and set an standarized structure to build and package C extensions in your gems. This is the result of expriences dealing with several Gems that required native extensions across platforms and different user configurations where details like portability and clarity of code were lacking. Koji build - For F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1405896 - For F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1405894
OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK Global are used. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package in part of reason has been given properly. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in koji (F-11 & Rawhide -- noarch). OK rpmlint is silent. OK final provides and requires look sane. -- %check is present (however, test need more work, not a blocker). OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK huge %docs has been moved to sub-package OK package installed properly According to ruby guideline, the package uses proper ruby specific packaging. ** APPROVED ** ps: sorry for have been so long.
No problem, thank you for reviewing this ticket. New Package CVS Request ======================= Package Name: rubygem-rake-compiler Short Description: Rake-based Ruby C Extension task generator Owners: mtasaka Branches: F-11 F-10 InitialCC: (nobody)
cvs done.
Rebuilt on all branches, submitted push requests on bodhi, closing. Thank you for the review and CVS procedure.
Package Change Request ======================= Package Name: rubygem-rake-compiler Owners: tremble Branches: EL-4 EL-5
Current package maintainers have no objections: BZ#1142428 Package Change Request ====================== Package Name: rubygem-rake-compiler New Branches: epel7 Owners: dfateyev
Git done (by process-git-requests).