Bug 503278
| Summary: | Review Request: nekobee-dssi - Acid sounds synthesizer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.1.7-2.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-24 19:27:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orcan Ogetbil
2009-05-30 16:24:36 UTC
Fedora review nekobee-dssi-0.1.7-1.fc10.src.rpm 2009-06-04 $ rpmlint *.rpm nekobee-dssi.spec nekobee-dssi.x86_64: W: dangling-relative-symlink /usr/bin/nekobee jack-dssi-host 3 packages and 1 specfiles checked; 0 errors, 1 warnings. * OK ! needs attention * rpmlint is OK - the dangling symlink is satisfied with a dependency * the package is named according to the guidelines * the specfile is is named after the package * the package is licensed under a Fedora approved license (GPLv2+) * the license tag matches the licens statements in the sources One file (src/nekobee_synth.h) says that part of the file is LGPLv2.1, but "LGPLv2.1 gives you permission to relicense the code under any version of the GPL since GPLv2" https://fedoraproject.org/wiki/Licensing#Footnote7 so this relicensing is permitted. * the license file (COPYING) is included as %doc * the spec file is written in legible English * source matches upstream e8b491b83e77f778df542d0066271d40 nekobee-0.1.7.tar.gz e8b491b83e77f778df542d0066271d40 SRPM/nekobee-0.1.7.tar.gz * package builds in mock (Fedora 10) * build requires are sane * package owns its directories or depend on packages that do * no duplicate files * permissions are sane and %files has %defattr * %clean clears buildroot * desktop files are installed using desktop-file-install * package does not own other's directories * %install clear buildroot * installed filenames are UTF8 ! the package installs an icon file but does not have any icon cache handling scriptlets. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Thank you for the review. Spec URL: http://oget.fedorapeople.org/review/nekobee-dssi.spec SRPM URL: http://oget.fedorapeople.org/review/nekobee-dssi-0.1.7-2.fc11.src.rpm Changelog: 0.1.7-2 - Add icon cache scriptlet Package approved. Thanks for the review! New Package CVS Request ======================= Package Name: nekobee-dssi Short Description: Acid sounds synthesizer Owners: oget Branches: F-9 F-10 F-11 InitialCC: CVS done. nekobee-dssi-0.1.7-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/nekobee-dssi-0.1.7-2.fc11 nekobee-dssi-0.1.7-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/nekobee-dssi-0.1.7-2.fc10 nekobee-dssi-0.1.7-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/nekobee-dssi-0.1.7-2.fc9 nekobee-dssi-0.1.7-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update nekobee-dssi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-6133 nekobee-dssi-0.1.7-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nekobee-dssi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6229 nekobee-dssi-0.1.7-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nekobee-dssi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-6434 nekobee-dssi-0.1.7-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. nekobee-dssi-0.1.7-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. nekobee-dssi-0.1.7-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |