Bug 503278 - Review Request: nekobee-dssi - Acid sounds synthesizer
Summary: Review Request: nekobee-dssi - Acid sounds synthesizer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mattias Ellert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-30 16:24 UTC by Orcan Ogetbil
Modified: 2009-06-24 19:33 UTC (History)
2 users (show)

Fixed In Version: 0.1.7-2.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-24 19:27:03 UTC
Type: ---
Embargoed:
mattias.ellert: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Orcan Ogetbil 2009-05-30 16:24:36 UTC
Spec URL: http://oget.fedorapeople.org/review/nekobee-dssi.spec
SRPM URL: http://oget.fedorapeople.org/review/nekobee-dssi-0.1.7-1.fc10.src.rpm
Description: 
Since it was first released in 2004, the Disposable Soft Synth Interface has
allowed Linux audio users to have simple plugin software synthesizers. Over
time, the number of these has grown as users and coders have developed new
plugins for particular sounds. Now, nekosynth brings some new plugins to enrich
your sonic palette.

This package provides the nekobee DSSI plugin, which is suitable for recreating
those squelchy acid sounds.


rpmlint
   nekobee-dssi.x86_64: W: dangling-relative-symlink /usr/bin/nekobee jack-dssi-host
can be ignored since the package requires dssi


koji rawhide build:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1384757

Comment 1 Mattias Ellert 2009-06-04 14:13:22 UTC
Fedora review nekobee-dssi-0.1.7-1.fc10.src.rpm 2009-06-04

$ rpmlint *.rpm nekobee-dssi.spec 
nekobee-dssi.x86_64: W: dangling-relative-symlink /usr/bin/nekobee jack-dssi-host
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

* OK
! needs attention

* rpmlint is OK - the dangling symlink is satisfied with a dependency

* the package is named according to the guidelines

* the specfile is is named after the package

* the package is licensed under a Fedora approved license (GPLv2+)

* the license tag matches the licens statements in the sources

  One file (src/nekobee_synth.h) says that part of the file is
  LGPLv2.1, but "LGPLv2.1 gives you permission to relicense the code
  under any version of the GPL since GPLv2"

  https://fedoraproject.org/wiki/Licensing#Footnote7

  so this relicensing is permitted.

* the license file (COPYING) is included as %doc

* the spec file is written in legible English

* source matches upstream

e8b491b83e77f778df542d0066271d40  nekobee-0.1.7.tar.gz
e8b491b83e77f778df542d0066271d40  SRPM/nekobee-0.1.7.tar.gz

* package builds in mock (Fedora 10)

* build requires are sane

* package owns its directories or depend on packages that do

* no duplicate files

* permissions are sane and %files has %defattr

* %clean clears buildroot

* desktop files are installed using desktop-file-install

* package does not own other's directories

* %install clear buildroot

* installed filenames are UTF8

! the package installs an icon file but does not have any icon cache
  handling scriptlets. See

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Comment 2 Orcan Ogetbil 2009-06-05 03:01:23 UTC
Thank you for the review.

Spec URL: http://oget.fedorapeople.org/review/nekobee-dssi.spec
SRPM URL: http://oget.fedorapeople.org/review/nekobee-dssi-0.1.7-2.fc11.src.rpm

Changelog: 0.1.7-2
- Add icon cache scriptlet

Comment 3 Mattias Ellert 2009-06-05 03:48:44 UTC
Package approved.

Comment 4 Orcan Ogetbil 2009-06-05 03:56:13 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: nekobee-dssi
Short Description: Acid sounds synthesizer
Owners: oget
Branches: F-9 F-10 F-11
InitialCC:

Comment 5 Jason Tibbitts 2009-06-05 21:40:49 UTC
CVS done.

Comment 6 Fedora Update System 2009-06-06 03:28:01 UTC
nekobee-dssi-0.1.7-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/nekobee-dssi-0.1.7-2.fc11

Comment 7 Fedora Update System 2009-06-06 03:28:44 UTC
nekobee-dssi-0.1.7-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/nekobee-dssi-0.1.7-2.fc10

Comment 8 Fedora Update System 2009-06-06 03:29:27 UTC
nekobee-dssi-0.1.7-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/nekobee-dssi-0.1.7-2.fc9

Comment 9 Fedora Update System 2009-06-16 01:43:03 UTC
nekobee-dssi-0.1.7-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update nekobee-dssi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-6133

Comment 10 Fedora Update System 2009-06-16 01:55:13 UTC
nekobee-dssi-0.1.7-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nekobee-dssi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6229

Comment 11 Fedora Update System 2009-06-16 02:37:11 UTC
nekobee-dssi-0.1.7-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nekobee-dssi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-6434

Comment 12 Fedora Update System 2009-06-24 19:26:58 UTC
nekobee-dssi-0.1.7-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2009-06-24 19:32:24 UTC
nekobee-dssi-0.1.7-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2009-06-24 19:32:59 UTC
nekobee-dssi-0.1.7-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.