Bug 503590
| Summary: | Review Request: python-tgext-admin - Admin Controller add-on for basic TG identity model | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | Package Review | Assignee: | Brennan Ashton <bashton> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bashton, fedora-package-review, notting, pfrields |
| Target Milestone: | --- | Flags: | bashton:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.2.5-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-29 21:59:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 503586 | ||
| Bug Blocks: | 503591 | ||
|
Description
Luke Macken
2009-06-01 19:39:14 UTC
Sorry, wrong links: Spec URL: http://lmacken.fedorapeople.org/rpms/python-tgext-admin.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/python-tgext-admin-0.2.4-1.fc10.src.rpm Description: Admin Controller add-on for basic TG identity model Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1390409 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2037e3faf46e2c1077eae8b78dc1157b4ad97b6a tgext.admin-0.2.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. 1) where can I find python-tgext-crud? I can't install this on F-10. 2) you should change %define to %global sorry rpmlint output is not silent python-tgext-admin.noarch: E: zero-length /usr/lib/python2.6/site-packages/tgext/admin/test/lib/helpers.py python-tgext-admin.noarch: E: zero-length /usr/lib/python2.6/site-packages/tgext/admin/test/lib/base.py ping? ping? http://lmacken.fedorapeople.org/rpms/python-tgext-admin-0.2.4-2.fc10.src.rpm http://lmacken.fedorapeople.org/rpms/python-tgext-admin.spec * Sat Jun 27 2009 Luke Macken <lmacken> - 0.2.4-2 - Change %%define to %%global - Don't package the test suite http://koji.fedoraproject.org/koji/taskinfo?taskID=1443362 looks ok but where can I find python-tgext-crud? ping? The python-tgext-crud can be found in Bug #503586 I am not sure why Parag dropped this, but it looks good to me. I confirm the changes fix the issues noted, and APPROVE. Go ahead with CVS request. New Package CVS Request ====================== Package Name: python-tgext-admin Short Description: Admin Controller add-on for basic TG identity model Owners: lmacken Branches: F-10 F-11 EL-5 CVS done. python-tgext-admin-0.2.5-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-tgext-admin-0.2.5-1.el5 python-tgext-admin-0.2.5-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-tgext-admin-0.2.5-1.fc10 python-tgext-admin-0.2.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-tgext-admin-0.2.5-1.fc11 python-tgext-admin-0.2.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-tgext-admin'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0190 python-tgext-admin-0.2.5-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-tgext-admin'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8315 python-tgext-admin-0.2.5-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-tgext-admin'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8335 python-tgext-admin-0.2.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. python-tgext-admin-0.2.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. python-tgext-admin-0.2.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |