Bug 503590 - Review Request: python-tgext-admin - Admin Controller add-on for basic TG identity model
Summary: Review Request: python-tgext-admin - Admin Controller add-on for basic TG ide...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brennan Ashton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 503586
Blocks: 503591
TreeView+ depends on / blocked
 
Reported: 2009-06-01 19:39 UTC by Luke Macken
Modified: 2016-09-20 02:39 UTC (History)
4 users (show)

Fixed In Version: 0.2.5-1.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-29 21:59:53 UTC
Type: ---
Embargoed:
bashton: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Luke Macken 2009-06-01 19:39:14 UTC
Spec URL: http://lmacken.fedorapeople.org/rpms/python-tgext-crud.spec
SRPM URL: http://lmacken.fedorapeople.org/rpms/python-tgext-crud-0.2.4-1.fc10.src.rpm
Description: Admin Controller add-on for basic TG identity model

Comment 1 Luke Macken 2009-06-01 19:39:45 UTC
Sorry, wrong links:

Spec URL: http://lmacken.fedorapeople.org/rpms/python-tgext-admin.spec
SRPM URL:
http://lmacken.fedorapeople.org/rpms/python-tgext-admin-0.2.4-1.fc10.src.rpm
Description: Admin Controller add-on for basic TG identity model

Comment 2 Parag AN(पराग) 2009-06-03 04:32:56 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1390409
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2037e3faf46e2c1077eae8b78dc1157b4ad97b6a  tgext.admin-0.2.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

1) where can I find python-tgext-crud? I can't install this on F-10.
2) you should change %define to %global

Comment 3 Parag AN(पराग) 2009-06-03 04:36:24 UTC
sorry rpmlint output is not silent
python-tgext-admin.noarch: E: zero-length /usr/lib/python2.6/site-packages/tgext/admin/test/lib/helpers.py
python-tgext-admin.noarch: E: zero-length /usr/lib/python2.6/site-packages/tgext/admin/test/lib/base.py

Comment 4 Parag AN(पराग) 2009-06-08 04:10:21 UTC
ping?

Comment 5 Parag AN(पराग) 2009-06-24 08:23:17 UTC
ping?

Comment 6 Luke Macken 2009-06-27 21:52:01 UTC
http://lmacken.fedorapeople.org/rpms/python-tgext-admin-0.2.4-2.fc10.src.rpm
http://lmacken.fedorapeople.org/rpms/python-tgext-admin.spec

* Sat Jun 27 2009 Luke Macken <lmacken> - 0.2.4-2
- Change %%define to %%global
- Don't package the test suite

Comment 7 Parag AN(पराग) 2009-06-30 09:06:12 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=1443362

looks ok but where can I find python-tgext-crud?

Comment 8 Parag AN(पराग) 2009-07-06 13:08:31 UTC
ping?

Comment 9 Luke Macken 2009-07-21 21:23:10 UTC
The python-tgext-crud can be found in Bug #503586

Comment 10 Brennan Ashton 2009-07-26 18:38:24 UTC
I am not sure why Parag dropped this, but it looks good to me. I confirm the changes fix the issues noted, and APPROVE. Go ahead with CVS request.

Comment 11 Luke Macken 2009-07-31 01:17:16 UTC
New Package CVS Request
======================
Package Name: python-tgext-admin
Short Description: Admin Controller add-on for basic TG identity model
Owners: lmacken
Branches: F-10 F-11 EL-5

Comment 12 Jason Tibbitts 2009-07-31 21:13:50 UTC
CVS done.

Comment 13 Fedora Update System 2009-08-04 19:38:08 UTC
python-tgext-admin-0.2.5-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/python-tgext-admin-0.2.5-1.el5

Comment 14 Fedora Update System 2009-08-04 19:38:13 UTC
python-tgext-admin-0.2.5-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-tgext-admin-0.2.5-1.fc10

Comment 15 Fedora Update System 2009-08-04 19:38:18 UTC
python-tgext-admin-0.2.5-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-tgext-admin-0.2.5-1.fc11

Comment 16 Fedora Update System 2009-08-05 03:22:32 UTC
python-tgext-admin-0.2.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-tgext-admin'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0190

Comment 17 Fedora Update System 2009-08-07 04:55:45 UTC
python-tgext-admin-0.2.5-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-tgext-admin'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8315

Comment 18 Fedora Update System 2009-08-07 05:01:08 UTC
python-tgext-admin-0.2.5-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-tgext-admin'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8335

Comment 19 Fedora Update System 2009-09-29 21:59:47 UTC
python-tgext-admin-0.2.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2009-09-30 01:34:37 UTC
python-tgext-admin-0.2.5-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2009-09-30 01:35:20 UTC
python-tgext-admin-0.2.5-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.