Bug 504472
| Summary: | Review Request: rubygem-shotgun - Automatic reloading version of the rackup command | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Michal Ingeli <mi> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, mfojtik, mi, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-shotgun-0.4-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-19 19:42:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 504477 | ||
| Bug Blocks: | 504471 | ||
|
Description
Lubomir Rintel
2009-06-07 11:44:39 UTC
Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-shotgun.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-shotgun-0.3-2.fc11.src.rpm SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-shotgun.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-shotgun-0.3-3.fc11.src.rpm For the sake of review, I agree with all Michal's changes. # MUST: rpmlint must be run on every package. The output should be posted in the review.
rpmlint -i rubygem-shotgun-0.4-1.fc12.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# MUST: The package must be named according to the Package Naming Guidelines .
OK
# MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
OK
# MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
MIT
# MUST: The spec file must be written in American English.
OK
# MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
http://gems.rubyforge.org/gems
# MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
OK
# MUST: Header files must be in a -devel package.
No headers.
# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK
# MUST: All filenames in rpm packages must be valid UTF-8.
OK
Fixed revision number in SRPM: SPEC: http://mifo.sk/rubygem-shotgun.spec SRPM: http://mifo.sk/rubygem-shotgun-0.4-1.fc12.src.rpm New Package CVS Request ======================= Package Name: rubygem-shotgun Short Description: Automatic reloading version of the rackup command Owners: lkundrak mfojtik Branches: F-11 F-12 EL-5 CVS done. rubygem-shotgun-0.4-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-shotgun-0.4-1.fc12 rubygem-shotgun-0.4-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Is there a reason you have not built or even cvs commited branches for devel, F13 and EPEL5? I'd be happy to maintain EPEL5 branch (or comaintain the entire package). Without a package in F13, when I upgrade, I will lose rubygem-shotgun. That might be because I suck as a package maintainer, or it was a clever way to find a comaintainer. You decide :) Meanwhile, I approved your pkgdb requests and triggered builds for F-13 and devel. Thank you for noticing that. rubygem-shotgun-0.4-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-shotgun-0.4-1.fc11 rubygem-shotgun-0.4-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. New Package CVS Request ======================= Package Name: rubygem-shotgun Short Description: Automatic reloading version of the rackup command Owners: lkundrak mfojtik Branches: F-14 EL-6 New Package CVS Request ======================= Package Name: rubygem-shotgun Short Description: Automatic reloading version of the rackup command Owners: mfojtik Branches: EL-6 I'm not willing to maintain any ruby gems anymore and F-14 branch was created; fixing the request. New Package CVS Request ======================= Package Name: rubygem-shotgun Short Description: Automatic reloading version of the rackup command Owners: mfojtik stahnma Branches: F-14 EL-6 I am willing to maintain and have taken ownership in pkgdb. I am not sure what you want here. This is not a new package, so a New package request won't work. Do you want to change something on the package? Can you add a package change template with what you want done and reset the flag when ready? |