Bug 504472 - Review Request: rubygem-shotgun - Automatic reloading version of the rackup command
Summary: Review Request: rubygem-shotgun - Automatic reloading version of the rackup c...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Michal Ingeli
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 504477
Blocks: 504471
TreeView+ depends on / blocked
 
Reported: 2009-06-07 11:44 UTC by Lubomir Rintel
Modified: 2010-08-02 16:28 UTC (History)
5 users (show)

Fixed In Version: rubygem-shotgun-0.4-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-19 19:42:30 UTC
Type: ---
Embargoed:
mfojtik: fedora-review+


Attachments (Terms of Use)

Description Lubomir Rintel 2009-06-07 11:44:39 UTC
SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-shotgun.spec
SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-shotgun-0.3-1.fc11.src.rpm

Description:

This is an automatic reloading version of the rackup command that's shipped
with Rack. It can be used as an alternative to the complex reloading logic
provided by web frameworks or in environments that don't support
application reloading.

The shotgun command starts one of Rack's supported servers (e.g., mongrel,
thin, webrick) and listens for requests but does not load any part of the
actual application. Each time a request is received, it forks, loads the
application in the child process, processes the request, and exits the
child process. The result is clean, application-wide reloading of all
source files and templates on each request.

Comment 4 Lubomir Rintel 2010-01-07 14:34:23 UTC
For the sake of review, I agree with all Michal's changes.

Comment 5 Michal Fojtik 2010-01-08 15:33:27 UTC
#  MUST: rpmlint must be run on every package. The output should be posted in the review.

rpmlint -i rubygem-shotgun-0.4-1.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

# MUST: The package must be named according to the Package Naming Guidelines .

OK

# MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.

OK

# MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .

MIT

# MUST: The spec file must be written in American English.

OK

# MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.

http://gems.rubyforge.org/gems

# MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.

OK

# MUST: Header files must be in a -devel package. 

No headers.

# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 

OK

# MUST: All filenames in rpm packages must be valid UTF-8. 

OK

Comment 6 Michal Fojtik 2010-01-08 15:35:53 UTC
Fixed revision number in SRPM:

SPEC: http://mifo.sk/rubygem-shotgun.spec
SRPM: http://mifo.sk/rubygem-shotgun-0.4-1.fc12.src.rpm

Comment 7 Lubomir Rintel 2010-01-10 16:54:19 UTC
New Package CVS Request
=======================
Package Name: rubygem-shotgun
Short Description: Automatic reloading version of the rackup command
Owners: lkundrak mfojtik
Branches: F-11 F-12 EL-5

Comment 8 Jason Tibbitts 2010-01-12 03:51:39 UTC
CVS done.

Comment 9 Fedora Update System 2010-01-15 18:27:24 UTC
rubygem-shotgun-0.4-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-shotgun-0.4-1.fc12

Comment 10 Fedora Update System 2010-01-19 19:42:24 UTC
rubygem-shotgun-0.4-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Michael Stahnke 2010-04-19 17:10:23 UTC
Is there a reason you have not built or even cvs commited branches for devel, F13 and EPEL5?  I'd be happy to maintain EPEL5 branch (or comaintain the entire package). 

Without a package in F13, when I upgrade, I will lose rubygem-shotgun.

Comment 12 Lubomir Rintel 2010-04-19 18:13:20 UTC
That might be because I suck as a package maintainer, or it was a clever way to find a comaintainer. You decide :)

Meanwhile, I approved your pkgdb requests and triggered builds for F-13 and devel. Thank you for noticing that.

Comment 13 Fedora Update System 2010-05-13 15:17:26 UTC
rubygem-shotgun-0.4-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/rubygem-shotgun-0.4-1.fc11

Comment 14 Fedora Update System 2010-05-15 20:20:16 UTC
rubygem-shotgun-0.4-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Michal Fojtik 2010-08-02 08:23:37 UTC
New Package CVS Request
=======================
Package Name: rubygem-shotgun
Short Description: Automatic reloading version of the rackup command
Owners: lkundrak mfojtik
Branches: F-14 EL-6

Comment 16 Lubomir Rintel 2010-08-02 08:32:15 UTC
New Package CVS Request
=======================
Package Name: rubygem-shotgun
Short Description: Automatic reloading version of the rackup command
Owners: mfojtik
Branches: EL-6

I'm not willing to maintain any ruby gems anymore and F-14 branch was created; fixing the request.

Comment 17 Michael Stahnke 2010-08-02 13:54:15 UTC
New Package CVS Request
=======================
Package Name: rubygem-shotgun
Short Description: Automatic reloading version of the rackup command
Owners: mfojtik stahnma
Branches: F-14 EL-6   

I am willing to maintain and have taken ownership in pkgdb.

Comment 18 Kevin Fenzi 2010-08-02 16:27:58 UTC
I am not sure what you want here. 

This is not a new package, so a New package request won't work. 
Do you want to change something on the package? Can you add a package change
template with what you want done and reset the flag when ready?


Note You need to log in before you can comment on or make changes to this bug.