Bug 504477
| Summary: | Review Request: rubygem-launchy - Helper class for cross-platform launching of applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Michal Ingeli <mi> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, mfojtik, mi, notting, tdawson |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3.5-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-19 19:44:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 504480 | ||
| Bug Blocks: | 504472 | ||
|
Description
Lubomir Rintel
2009-06-07 11:45:05 UTC
Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-launchy.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-launchy-0.3.3-2.fc11.src.rpm SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-launchy.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-launchy-0.3.3-3.fc11.src.rpm * builds in mock * rpmlint silent * source matches upstream * naming OK * clean spec file, american english * naming OK * file list, doc list OK * provides/requires OK - fix license, should be BSD [1] Note that provided spec file and srpm spec file differs. [1] http://copiousfreetime.rubyforge.org/launchy/LICENSE.html For the sake of review, I agree with all Michal's changes. # MUST: rpmlint must be run on every package. The output should be posted in the review.
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# MUST: The package must be named according to the Package Naming Guidelines .
OK
# MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
OK
# MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK
# MUST: The spec file must be written in American English.
OK
# MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
http://gems.rubyforge.org/gems
# MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
OK
# MUST: Header files must be in a -devel package.
There is no headers.
# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK
# MUST: All filenames in rpm packages must be valid UTF-8.
Fixed revision number: SPEC: http://mifo.sk/rubygem-launchy.spec SRPM: http://mifo.sk/rubygem-launchy-0.3.5-1.fc12.src.rpm New Package CVS Request ======================= Package Name: rubygem-launchy Short Description: Helper class for cross-platform launching of applications Owners: lkundrak mfojtik Branches: F-11 F-12 EL-5 CVS done (by process-cvs-requests.py) rubygem-launchy-0.3.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-launchy-0.3.5-1.fc12 rubygem-launchy-0.3.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Is there a reason launchy was built for EPEL5 but never pushed into epel5-testing? If you need a com-maintainer, I'd be happy to do it for EPEL. (In reply to comment #12) > Is there a reason launchy was built for EPEL5 but never pushed into > epel5-testing? More like I had no reason to push it there. Michael, feel free to add yourself to whichever branches you'd like to maintain: https://admin.fedoraproject.org/pkgdb/acls/name/rubygem-launchy New Package CVS Request ======================= Package Name: rubygem-launchy Short Description: Helper class for cross-platform launching of applications Owners: lkundrak mfojtik Branches: F-14 EL-6 New Package CVS Request ======================= Package Name: rubygem-launchy Short Description: Helper class for cross-platform launching of applications Owners: mfojtik Branches: EL-6 I'm not willing to maintain any ruby gems anymore and F-14 branch was created; fixing the request. New Package CVS Request ======================= Package Name: rubygem-launchy Short Description: Helper class for cross-platform launching of applications Owners: lkundrak mfojtik Branches: F-14 EL-6 I am willing to maintain and have taken ownership in pkgdb. Please ensure all branches are created. New Package CVS Request ======================= Package Name: rubygem-launchy Short Description: Helper class for cross-platform launching of applications Owners: stahnma mfojtik Branches: F-14 EL-6 I am willing to maintain and have taken ownership in pkgdb. Please ensure all branches are created. (forgot to change owner in last post) All branches are there. Please add a package change template if you want anything further done. Package Change Request ====================== Package Name: rubygem-launchy New Branches: epel7 Owners: tdawson Git done (by process-git-requests). |