Bug 504521
Summary: | Review Request: SevenZip - Java SDK for LZMA | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
Component: | Package Review | Assignee: | Rakesh Pandit <rpandit> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, fkooman, kevin, notting |
Target Milestone: | --- | Flags: | rpandit:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 4.65-1.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-06-27 17:58:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 492203 |
Description
Orcan Ogetbil
2009-06-07 20:14:12 UTC
will review shortly package naming -- done api-subpackage -- done [rakesh@dhcp7-204 SevenZip-4.65-1.fc11.x86_64]$ tree . `-- usr |-- lib64 | `-- gcj | `-- SevenZip | |-- SevenZip-4.65.jar.db | `-- SevenZip-4.65.jar.so `-- share |-- doc | `-- SevenZip-4.65 | |-- 7zFormat.txt | |-- Methods.txt | |-- history.txt | `-- lzma.txt `-- java |-- SevenZip-4.65.jar `-- SevenZip.jar -> SevenZip-4.65.jar 8 directories, 8 files Symlink between project name and commonly used jar file name done jar files going to %{_javadir} - done package naming - fails I am confused about wether SevenZip would be right name for this packages .. will confirm in some time. spec file language -- sane spec file - legible [rakesh@dhcp7-204 SPECS]$ md5sum lzma465.tar.bz2 29d5ffd03a5a3e51aef6a74e9eafb759 lzma465.tar.bz2 [rakesh@dhcp7-204 SPECS]$ md5sum SevenZip-4.65-1.fc11.src/lzma465.tar.bz2 29d5ffd03a5a3e51aef6a74e9eafb759 SevenZip-4.65-1.fc11.src/lzma465.tar.bz2 md5sum matches -- done Compiles -- successfully Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1433244 rpmlint output - mentioned buildrequires - fine %files - fine -doc package - fine Summary: naming .. I am in doubt will confirm in some time. Thanks for the review! SevenZip source tree is being copied to other programs' tarballs. frinika (bug #492203) is one of them. I made it a separate package as a Fedora requirement. On the other hand this source tree of lzma has the lzma framework for C/C++/C sharp/Java. The former two are already covered in the current lzma package we have in Fedora. I am not much interested in C sharp, I am sure only very few of us are. That leaves the Java, which is what this package is. Yeah .. I had posted it fedora-devel regarding .. "what would be most suited name for this" .. may you follow up there? I don't think SevenZip is apt. May you check this .. I did not see any debuginfo file ? [rakesh@dhcp7-204 new]$ rpmlint /home/rakesh/rpmbuild/RPMS/x86_64/SevenZip-4.65-1.fc11.x86_64.rpm SevenZip.x86_64: W: unstripped-binary-or-object /usr/lib64/gcj/SevenZip/SevenZip-4.65.jar.so 1 packages and 0 specfiles checked; 0 errors, 1 warnings. I am okay with SevenZip ... may you check about debuginfo file ? as suggested in comment #4 My system builds the debuginfo package. You need to install redhat-rpm-config or use mock. APPROVED Thanks for the package review! New Package CVS Request ======================= Package Name: SevenZip Short Description: Java SDK for LZMA Owners: oget Branches: F-10 F-11 InitialCC: CVS done. SevenZip-4.65-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/SevenZip-4.65-1.fc11 SevenZip-4.65-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/SevenZip-4.65-1.fc10 Package in rawhide now. Thanks everyone. The name really needs to be changed, see also the feedback on the mailing list. Rakesh, why did you first ask for feedback and then ignore it? It would have been trivial to fix this right at the beginning, now this needs to be reviewed again, and as it has been already built, the badly-named source package can't easily be removed. :-( Next time please decide the naming BEFORE approving a package! Oh, and also no thanks for oget for filing the CVS request without sorting out the name. (In reply to comment #14) > The name really needs to be changed, see also the feedback on the mailing list. > Rakesh, why did you first ask for feedback and then ignore it? It would have > been trivial to fix this right at the beginning, now this needs to be reviewed > again, and as it has been already built, the badly-named source package can't > easily be removed. :-( Next time please decide the naming BEFORE approving a > package! I asked for views and saw the response yesterday and decided based on it that "SevenZip" is apt and it is. Huh? In the mailing list thread, the submitter (Orcan Ogetbil) was the only one who thinks SevenZip is the correct name. SevenZip-4.65-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. SevenZip-4.65-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |