Bug 504710

Summary:	Review Request: rubygem-gettext_rails - Localization support for Ruby on Rails(>=2.3) by Ruby-GetText-Package
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Xavier Lamien <lxtnow>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, jboggs, lxtnow, notting
Target Milestone:	---	Flags:	lxtnow: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-06-27 04:15:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	504707, 504709
Bug Blocks:

Description Mamoru TASAKA 2009-06-08 22:11:21 UTC

Spec URL: http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/rubygem-gettext_rails.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/rubygem-gettext_rails-2.0.4-1.fc.src.rpm
Description: 
gettext_rails provides the localization for Ruby on Rails-2.3 or later
using Ruby-GetText-Package.

* Autodetect client locale using locale/locale_rails.
* Easy maintenance of translations to use powerful tools for gettext family.
* Model translation using gettext_activerecord.
* Localization for some helpers.
* Works with other Rails I18n backend.
  * Note that gettext_rails is not the one of I18n backend.
* Thread safe.

(koji) scratch build
- For F-12: http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/Mock_results/
- For F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1400009

Note that currently this package is for F-11 and above.

Comment 1 Mamoru TASAKA 2009-06-12 15:21:35 UTC

http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/rubygem-gettext_rails.spec
http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/rubygem-gettext_rails-2.0.4-2.fc.src.rpm

* Fri Jun 12 2009 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 2.0.4-2
- Also mark gettext mo files under test/ directory with %%lang

Comment 2 Mamoru TASAKA 2009-06-15 17:35:58 UTC

http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/rubygem-gettext_rails-2.0.4-3.fc.src.rpm
http://mtasaka.fedorapeople.org/Review_request/Ruby_on_Rails/rubygem-gettext_rails.spec

* Tue Jun 16 2009 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 2.0.4-3
- Remove COPYING for now
- Recreate gettext .mo file

Comment 3 Xavier Lamien 2009-06-25 21:49:48 UTC

OK	source files match upstream
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK      Global are used.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2 or Ruby). License text included in package in part of reason has been given properly.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	%clean is present.
OK	package builds in koji (Rawhide/x86_64).
OK	rpmlint is silent.
OK	final provides and requires look sane.
--	%check is present (however, test need more work, not a blocker).
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	huge %docs has been moved to sub-package 
OK      package installed properly

According to ruby guideline, the package uses proper ruby specific packaging.


** APPROVED **

Comment 4 Xavier Lamien 2009-06-25 21:51:00 UTC

woops.
Package is noarch.

Comment 5 Mamoru TASAKA 2009-06-26 04:23:01 UTC

Thank you!

-----------------------------------------------------------
New Package CVS Request
=======================
Package Name:       rubygem-gettext_rails
Short Description:  Localization support for Ruby on Rails by Ruby-GetText-Package
Owners:             mtasaka
Branches:           F-11
InitialCC:          (nobody)

Comment 6 Jason Tibbitts 2009-06-27 00:34:12 UTC

CVS done.

Comment 7 Mamoru TASAKA 2009-06-27 04:15:24 UTC

Rebuilt on all archs, submitted push request on bodhi, closing.

Thank you for the review and CVS procedure.