Bug 505050

Summary: Wrong NULL check
Product: [Fedora] Fedora Reporter: Curious <hernio.steven>
Component: mdsplibAssignee: Matthias Saou <matthias>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: matthias
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.11-9.fc9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-16 01:27:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Curious 2009-06-10 13:58:13 UTC
Description of problem: Using the library may lead to Segmentation fault.


How reproducible: At any use of the library with a lot of lightning information


Steps to Reproduce:
1. download a metar file, tgftp.nws.noaa.gov anonymous
2. Use the dcdMETAR function on a high number of statement (using one by one may not lead to this problem.
  
Actual results: May cause a Segmentation fault => software crash.


Additional info: The problem is due to a wrong NULL verification.

Line : 1990 - 1993 : 
      if( *string == NULL )
         return FALSE;
 
      (--string);

Should be : 
      (--string);

      if( *string == NULL )
         return FALSE;

Comment 1 Matthias Saou 2009-06-11 10:09:55 UTC
Nice catch. I'm rebuilding the devel package right now, then I'll also backport the change, as well as another recent fix by Karsten Hopp, to all current branches.

Comment 2 Fedora Update System 2009-06-11 11:14:57 UTC
mdsplib-0.11-9.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mdsplib-0.11-9.fc10

Comment 3 Fedora Update System 2009-06-11 11:15:01 UTC
mdsplib-0.11-9.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/mdsplib-0.11-9.fc9

Comment 4 Fedora Update System 2009-06-11 11:15:07 UTC
mdsplib-0.11-9.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/mdsplib-0.11-9.fc11

Comment 5 Fedora Update System 2009-06-16 01:27:02 UTC
mdsplib-0.11-9.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2009-06-16 01:40:35 UTC
mdsplib-0.11-9.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2009-06-16 01:55:42 UTC
mdsplib-0.11-9.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.