Bug 505599

Summary: cfdg not built with $RPM_OPT_FLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: cfdgAssignee: Gwyn Ciesla <gwync>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: gwync
Target Milestone: ---Keywords: Patch, Regression, Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-16 18:41:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968    
Attachments:
Description Flags
Build with $RPM_OPT_FLAGS none

Description Ville Skyttä 2009-06-12 14:49:20 UTC
Created attachment 347580 [details]
Build with $RPM_OPT_FLAGS

Fix attached, see bug 496968 for more info.

Comment 1 Gwyn Ciesla 2009-06-12 15:03:47 UTC
Does this patch not *remove* optflags?  Am I misreading it?

Comment 2 Ville Skyttä 2009-06-12 16:55:36 UTC
Yes, you're misreading it :).  But it's a tough one to read as it patches a patch.  Anyway, the end result is that before applying the patch I submitted, ContextFreeSource2.2/Makefile ends up having:

+CPPFLAGS += $(OPTFLAGS)

...(yes, there's a stray + at the beginning of line), and after my patch:

CPPFLAGS += $(OPTFLAGS)

Comment 3 Gwyn Ciesla 2009-06-15 18:01:08 UTC
Gotcha.

Committed and built. Thanks!

Comment 4 Ville Skyttä 2009-06-16 18:22:32 UTC
Unfortunately the 2.2-2 Rawhide build was bitten by bug 505774:
http://kojipkgs.fedoraproject.org/packages/cfdg/2.2/2.fc12/data/logs/x86_64/build.log

A simple bump and rebuild should fix it.

Comment 5 Gwyn Ciesla 2009-06-16 18:41:50 UTC
Bah.

Done.  Thanks!