Bug 505599 - cfdg not built with $RPM_OPT_FLAGS
Summary: cfdg not built with $RPM_OPT_FLAGS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cfdg
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DebugInfo
TreeView+ depends on / blocked
 
Reported: 2009-06-12 14:49 UTC by Ville Skyttä
Modified: 2009-06-16 18:41 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-06-16 18:41:50 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Build with $RPM_OPT_FLAGS (1.19 KB, patch)
2009-06-12 14:49 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2009-06-12 14:49:20 UTC
Created attachment 347580 [details]
Build with $RPM_OPT_FLAGS

Fix attached, see bug 496968 for more info.

Comment 1 Gwyn Ciesla 2009-06-12 15:03:47 UTC
Does this patch not *remove* optflags?  Am I misreading it?

Comment 2 Ville Skyttä 2009-06-12 16:55:36 UTC
Yes, you're misreading it :).  But it's a tough one to read as it patches a patch.  Anyway, the end result is that before applying the patch I submitted, ContextFreeSource2.2/Makefile ends up having:

+CPPFLAGS += $(OPTFLAGS)

...(yes, there's a stray + at the beginning of line), and after my patch:

CPPFLAGS += $(OPTFLAGS)

Comment 3 Gwyn Ciesla 2009-06-15 18:01:08 UTC
Gotcha.

Committed and built. Thanks!

Comment 4 Ville Skyttä 2009-06-16 18:22:32 UTC
Unfortunately the 2.2-2 Rawhide build was bitten by bug 505774:
http://kojipkgs.fedoraproject.org/packages/cfdg/2.2/2.fc12/data/logs/x86_64/build.log

A simple bump and rebuild should fix it.

Comment 5 Gwyn Ciesla 2009-06-16 18:41:50 UTC
Bah.

Done.  Thanks!


Note You need to log in before you can comment on or make changes to this bug.