Bug 505965
| Summary: | Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.1.2-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-07 15:28:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kevin Fenzi
2009-06-15 00:44:14 UTC
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1414340 + rpmlint is silent for SRPM and for RPM. + source files match upstream url. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Should: 1) change %define to %global APPROVED. Thanks for the quick review! I've talked to the upstream author and he's going to make a number of enhancements in the next few days. I am going to wait for those to land before importing this. Thanks again. Got any updates from upstream? Yeah, sorry for the delay here. ;( He has just checked in a bunch of changes to his devel branch that he wants me to test before landing in stable. I will try and do that in the next few days and hopefully thats the version I can get imported. If not, he did tag version 0.1 in the stable repo with what we have now, so I can just check that in if there are problems with the new changes. :) Sorry again for the delay. ok, upstream just pushed out version 0.1.1. ;) This is what I will be importing: Spec URL: http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot.spec SRPM URL: http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot-0.1.1-1.fc12.src.rpm New Package CVS Request ======================= Package Name: supybot-meetbot Short Description: Plugin for Supybot for handling IRC meetings Owners: kevin Branches: devel F-11 EL-5 InitialCC: cvs done. supybot-meetbot-0.1.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-1.fc11 supybot-meetbot-0.1.1-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-1.el5 supybot-meetbot-0.1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-2.fc11 supybot-meetbot-0.1.1-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-2.el5 I am sorry kevin that I seem to overlooked at spec and approved with wrong install location. Thanks for fixing this immediately. No problem. Totally my fault for not checking it more before I imported. ;( Anyhow, it's all set now... supybot-meetbot-0.1.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.2-1.fc11 supybot-meetbot-0.1.2-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.2-1.el5 supybot-meetbot-0.1.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. supybot-meetbot-0.1.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: supybot-meetbot New Branches: epel7 Owners: kevin InitialCC: Git done (by process-git-requests). |