Bug 505965 - Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-14 20:44 EDT by Kevin Fenzi
Modified: 2014-11-12 18:02 EST (History)
3 users (show)

See Also:
Fixed In Version: 0.1.2-1.fc11
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-07-07 11:28:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Kevin Fenzi 2009-06-14 20:44:14 EDT
Spec URL: http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot.spec
SRPM URL: http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot-0-0.1.20090614darcs.fc12.src.rpm
Description: 

MeatBot is designed to assist in running meetings, taking notes, and so on.
It is in pure python, as a plugin to supybot. However, there is a clear
distinction between meeting-code and IRC-code, so it should be relatively
easy to port to other bots. It is under the supybot license (3-clause BSD).

There has not been a formal release yet, but upstream is ok with just packaging up a darcs checkout version now.
Comment 1 Parag AN(पराग) 2009-06-15 02:49:16 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1414340
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Should:
1) change %define to %global
APPROVED.
Comment 2 Kevin Fenzi 2009-06-15 21:38:30 EDT
Thanks for the quick review!

I've talked to the upstream author and he's going to make a number of enhancements in the next few days. I am going to wait for those to land before importing this. 

Thanks again.
Comment 3 Parag AN(पराग) 2009-07-01 03:09:04 EDT
Got any updates from upstream?
Comment 4 Kevin Fenzi 2009-07-01 11:31:37 EDT
Yeah, sorry for the delay here. ;( 

He has just checked in a bunch of changes to his devel branch that he wants me to test before landing in stable. I will try and do that in the next few days and hopefully thats the version I can get imported. 

If not, he did tag version 0.1 in the stable repo with what we have now, so I can just check that in if there are problems with the new changes. :) 

Sorry again for the delay.
Comment 5 Kevin Fenzi 2009-07-06 23:44:05 EDT
ok, upstream just pushed out version 0.1.1. ;) 

This is what I will be importing: 

Spec URL:
http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot.spec
SRPM URL:
http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot-0.1.1-1.fc12.src.rpm

New Package CVS Request
=======================
Package Name: supybot-meetbot 
Short Description: Plugin for Supybot for handling IRC meetings
Owners: kevin
Branches: devel F-11 EL-5
InitialCC:
Comment 6 Kevin Fenzi 2009-07-07 00:02:00 EDT
cvs done.
Comment 7 Fedora Update System 2009-07-07 00:50:54 EDT
supybot-meetbot-0.1.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-1.fc11
Comment 8 Fedora Update System 2009-07-07 00:54:13 EDT
supybot-meetbot-0.1.1-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-1.el5
Comment 9 Fedora Update System 2009-07-07 02:43:23 EDT
supybot-meetbot-0.1.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-2.fc11
Comment 10 Fedora Update System 2009-07-07 02:48:15 EDT
supybot-meetbot-0.1.1-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-2.el5
Comment 11 Parag AN(पराग) 2009-07-07 03:10:29 EDT
I am sorry kevin that I seem to overlooked at spec and approved with wrong install location.
Thanks for fixing this immediately.
Comment 12 Kevin Fenzi 2009-07-07 11:28:21 EDT
No problem. Totally my fault for not checking it more before I imported. ;( 

Anyhow, it's all set now...
Comment 13 Fedora Update System 2009-07-15 14:10:58 EDT
supybot-meetbot-0.1.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.2-1.fc11
Comment 14 Fedora Update System 2009-07-15 14:19:06 EDT
supybot-meetbot-0.1.2-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.2-1.el5
Comment 15 Fedora Update System 2009-08-03 22:28:44 EDT
supybot-meetbot-0.1.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 16 Fedora Update System 2009-08-04 20:30:54 EDT
supybot-meetbot-0.1.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Kevin Fenzi 2014-11-12 17:20:19 EST
Package Change Request
======================
Package Name: supybot-meetbot
New Branches: epel7
Owners: kevin
InitialCC:
Comment 18 Gwyn Ciesla 2014-11-12 18:02:56 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.