Bug 506174
| Summary: | Review Request: qtdmm - a digital multimeter readout software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrew Zabolotny <anpaza> |
| Component: | Package Review | Assignee: | Chitlesh GOORAH <chitlesh> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | chitlesh, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | chitlesh:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-29 22:26:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andrew Zabolotny
2009-06-15 20:39:14 UTC
Sorry, I missed the URL to the spec file. The correct one is: https://fedorahosted.org/fedora-electronic-lab/attachment/ticket/23/qtdmm.6.spec #1: remove requires qt3 yum automatically deduces the dependencies in more cases. You can verify it with $ rpm -qR qtdmm .... libqt-mt.so.3 .... $ yum whatprovides libqt-mt.so.3 #2: package name should be QtDMM instead of qtdmm. It should be the same as what upstream uses, unless it is a trac/eclipse plugin #3: Add this --vendor="" after desktop-file-install \ This will ensure that for the EL-5 branch, the build does not fail Okay, did it. btw what's the issue with EL-5? why it would want to set vendor to empty (which is not set in the .desktop file anyway). Updated spec file: http://cs.ozerki.net/zap/pub/rpm/QtDMM.spec Updated SRPM: http://cs.ozerki.net/zap/pub/rpm/QtDMM-0.8.12-1.fc11.zap.src.rpm Any news on this? Sorry, I was in Berlin for the Fedora's FUDCon. Can you fix all the rpmlint warnings on each generated rpm ? Ok, fixed the tab issue: [3|zap@zap|~/rpm/SRPMS]rpmlint -v QtDMM-0.8.12-1.fc11.zap.src.rpm QtDMM.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. the updated spec and src.rpm is on the same URLs as above. There are still some warnings on the debug rpm. Fixed, the RPMs on the same URL as above. Approved. Please give me your FAS username so that I can sponsor you. Please read the rest of the packaging procedure to push Qtdmm to the repositories: https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and_Set_Owner My FAS username is zap. I've tried to build the package on koji for the four main architectures and it worked fine. New Package CVS Request ======================= Package Name: QtDMM Short Description: QtDMM is a DMM readout software including a configurable recorder. Owners: zap Branches: F-10 F-11 InitialCC: chitlesh The description should not contain the package name, so I removed "QtDMM is a". Otherwise, CVS done. Andrew please continue the process as described on this page: https://fedoraproject.org/wiki/PackageMaintainers/Join#Check_out_the_module Ping ? please refer to comment #13 Sorry, was tracked away by everyday life. Have commited everything to F-10, F-11 and -devel. Did a successful test build for everyone. Should I do 'make update' now for both distros? Yes you should : https://admin.fedoraproject.org/updates Done, needs karma to be pushed into stable. next time, do add the bug number while you pushed to stable so that bodhi automatically closes this bug. Hence I'm closing it manually and including QtDMM on FEL's livedvd for F-12 Package Change Request ====================== Package Name: QtDMM Short Description: a digital multimeter readout software New Branches: EL-5 EL-6 Owners:chitlesh Have you asked 'zap' if he would like to maintain this for EL5/EL6? I have Centos5 installed on one of my machines. If that's enough for doing preventive testing of the package, I can do it. Ok then, please do it :) |