Bug 506174 - Review Request: qtdmm - a digital multimeter readout software
Summary: Review Request: qtdmm - a digital multimeter readout software
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Chitlesh GOORAH
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-15 20:39 UTC by Andrew Zabolotny
Modified: 2010-08-10 21:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-29 22:26:09 UTC
Type: ---
Embargoed:
chitlesh: fedora-review+


Attachments (Terms of Use)

Description Andrew Zabolotny 2009-06-15 20:39:14 UTC
Spec URL: https://fedorahosted.org/fedora-electronic-lab/attachment/ticket/23/qtdmm.5.spec
SRPM URL: http://cs.ozerki.net/zap/pub/rpm/qtdmm-0.8.12-1.fc9.src.rpm
Description:
QtDMM is a DMM readout software including a configurable recorder. The recorder features manual start, scheduled start (at a given time), triggered automatic start when given thresholds are reached, and the ability to display more than one value from the multimeter. It was written for Metex (and compatible like VOLTCRAFT) multimeter which use an 14 byte protocol. Later several more protocols have been added.

# rpmlint qtdmm-0.8.12-1.fc9.src.rpm                                 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Respective Fedora Electronic Lab ticket here:
https://fedorahosted.org/fedora-electronic-lab/ticket/23

This is my first package ever submitted to Fedora, so I need a sponsor.

Comment 1 Andrew Zabolotny 2009-06-15 20:53:55 UTC
Sorry, I missed the URL to the spec file.
The correct one is:
https://fedorahosted.org/fedora-electronic-lab/attachment/ticket/23/qtdmm.6.spec

Comment 2 Chitlesh GOORAH 2009-06-18 20:29:01 UTC
#1: remove requires qt3

yum automatically deduces the dependencies in more cases. You can verify it with

$ rpm -qR qtdmm
....
libqt-mt.so.3
....

$ yum whatprovides libqt-mt.so.3

#2: package name should be QtDMM instead of qtdmm. It should be the same as what upstream uses, unless it is a trac/eclipse plugin

#3: Add this --vendor="" after desktop-file-install \
This will ensure that for the EL-5 branch, the build does not fail

Comment 3 Andrew Zabolotny 2009-06-20 10:54:38 UTC
Okay, did it.

btw what's the issue with EL-5? why it would want to set vendor to empty (which is not set in the .desktop file anyway).

Updated spec file: http://cs.ozerki.net/zap/pub/rpm/QtDMM.spec
Updated SRPM: http://cs.ozerki.net/zap/pub/rpm/QtDMM-0.8.12-1.fc11.zap.src.rpm

Comment 4 Andrew Zabolotny 2009-07-02 16:43:27 UTC
Any news on this?

Comment 5 Chitlesh GOORAH 2009-07-05 12:49:41 UTC
Sorry, I was in Berlin for the Fedora's FUDCon.


Can you fix all the rpmlint warnings on each generated rpm ?

Comment 6 Andrew Zabolotny 2009-07-05 15:04:54 UTC
Ok, fixed the tab issue:

[3|zap@zap|~/rpm/SRPMS]rpmlint -v QtDMM-0.8.12-1.fc11.zap.src.rpm                         
QtDMM.src: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

the updated spec and src.rpm is on the same URLs as above.

Comment 7 Chitlesh GOORAH 2009-07-05 15:08:59 UTC
There are still some warnings on the debug rpm.

Comment 8 Andrew Zabolotny 2009-07-25 18:48:25 UTC
Fixed, the RPMs on the same URL as above.

Comment 9 Chitlesh GOORAH 2009-08-14 20:34:48 UTC
Approved.

Please give me your FAS username so that I can sponsor you.

Please read the rest of the packaging procedure to push Qtdmm to the repositories:
https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and_Set_Owner

Comment 10 Andrew Zabolotny 2009-08-15 07:00:56 UTC
My FAS username is zap.
I've tried to build the package on koji for the four main architectures and it worked fine.

Comment 11 Andrew Zabolotny 2009-08-19 20:56:36 UTC
New Package CVS Request
=======================
Package Name: QtDMM
Short Description: QtDMM is a DMM readout software including a configurable recorder.
Owners: zap
Branches: F-10 F-11
InitialCC: chitlesh

Comment 12 Jason Tibbitts 2009-08-19 21:43:07 UTC
The description should not contain the package name, so I removed "QtDMM is a".

Otherwise, CVS done.

Comment 13 Chitlesh GOORAH 2009-08-20 21:32:50 UTC
Andrew please continue the process as described on this page:

https://fedoraproject.org/wiki/PackageMaintainers/Join#Check_out_the_module

Comment 14 Chitlesh GOORAH 2009-08-28 10:29:28 UTC
Ping ? please refer to comment #13

Comment 15 Andrew Zabolotny 2009-08-28 21:51:42 UTC
Sorry, was tracked away by everyday life.

Have commited everything to F-10, F-11 and -devel. Did a successful test build for everyone.

Should I do 'make update' now for both distros?

Comment 16 Chitlesh GOORAH 2009-08-29 08:24:27 UTC
Yes you should :

https://admin.fedoraproject.org/updates

Comment 17 Andrew Zabolotny 2009-08-29 21:44:55 UTC
Done, needs karma to be pushed into stable.

Comment 18 Chitlesh GOORAH 2009-08-29 22:26:09 UTC
next time, do add the bug number while you pushed to stable so that bodhi automatically closes this bug. 

Hence I'm closing it manually and including QtDMM on FEL's livedvd for F-12

Comment 19 Chitlesh GOORAH 2010-07-18 10:30:09 UTC
Package Change Request
======================
Package Name: QtDMM
Short Description: a digital multimeter readout software
New Branches: EL-5 EL-6
Owners:chitlesh

Comment 20 Kevin Fenzi 2010-07-19 04:32:45 UTC
Have you asked 'zap' if he would like to maintain this for EL5/EL6?

Comment 21 Andrew Zabolotny 2010-07-19 11:26:26 UTC
I have Centos5 installed on one of my machines. If that's enough for doing preventive testing of the package, I can do it.

Comment 22 Chitlesh GOORAH 2010-08-10 21:46:51 UTC
Ok then, please do it :)


Note You need to log in before you can comment on or make changes to this bug.