Bug 506231

Summary: Review Request: hunspell-smj - Lule Sami hunspell dictionaries
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-17 19:42:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2009-06-16 08:37:04 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-smj.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-smj-1.0-0.1.beta7.fc11.src.rpm
Description: Lule Sami hunspell dictionaries

Comment 1 Parag AN(पराग) 2009-06-16 09:14:08 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1417476
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
31029eb7f716e5430f404503e23903fa9591c6d3  hunspell-smj.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

Comment 2 Caolan McNamara 2009-06-16 10:05:59 UTC
New Package CVS Request
=======================
Package Name: hunspell-smj
Short Description: Lule Sami hunspell dictionaries
Owners: caolanm
Branches: devel
InitialCC:

Comment 3 Jason Tibbitts 2009-06-17 16:34:13 UTC
CVS done.