Bug 506231 - Review Request: hunspell-smj - Lule Sami hunspell dictionaries
Review Request: hunspell-smj - Lule Sami hunspell dictionaries
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-16 04:37 EDT by Caolan McNamara
Modified: 2009-06-17 15:42 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-06-17 15:42:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Caolan McNamara 2009-06-16 04:37:04 EDT
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-smj.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-smj-1.0-0.1.beta7.fc11.src.rpm
Description: Lule Sami hunspell dictionaries
Comment 1 Parag AN(पराग) 2009-06-16 05:14:08 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1417476
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
31029eb7f716e5430f404503e23903fa9591c6d3  hunspell-smj.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.
Comment 2 Caolan McNamara 2009-06-16 06:05:59 EDT
New Package CVS Request
=======================
Package Name: hunspell-smj
Short Description: Lule Sami hunspell dictionaries
Owners: caolanm
Branches: devel
InitialCC:
Comment 3 Jason Tibbitts 2009-06-17 12:34:13 EDT
CVS done.

Note You need to log in before you can comment on or make changes to this bug.