Bug 507773

Summary:	Review Request: python-daemon - Library to implement a well-behaved Unix daemon process
Product:	[Fedora] Fedora	Reporter:	kushaldas@gmail.com <mail>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-10-08 10:10:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description kushaldas@gmail.com 2009-06-24 07:06:06 UTC

Spec URL: http://kushal.fedorapeople.org/packages/python-daemon.spec
SRPM URL: http://kushal.fedorapeople.org/packages/python-daemon-1.4.6-1.fc11.src.rpm
Description: This library implements the well-behaved daemon specification of PEP 3143, "Standard daemon process library".

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1433003

Comment 1 Parag AN(पराग) 2009-06-24 07:57:19 UTC

Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1433042
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
874e40daa053644e2899f7def181a252087003e3  python-daemon-1.4.6.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions:
1) I don't get why you need version_info_fix.patch. Better do same in spec as
sed -i -e "s|#!/usr/bin/env python||" daemon/version/version_info.py
2) Should use %global instead %define

APPROVED.

Comment 2 kushaldas@gmail.com 2009-06-24 08:45:53 UTC

New Package CVS Request
=======================
Package Name: python-daemon
Short Description:  Library to implement a well-behaved Unix daemon process
Owners: kushal
Branches: F-11
InitialCC: kushal

Comment 3 Kevin Fenzi 2009-06-24 18:20:24 UTC

cvs done.

Comment 4 Parag AN(पराग) 2009-07-01 06:21:36 UTC

is this built for requested branches?

Comment 5 Parag AN(पराग) 2009-07-06 15:54:29 UTC

ping?

Comment 6 Parag AN(पराग) 2009-07-10 09:01:00 UTC

ping?

Comment 7 Parag AN(पराग) 2009-07-15 16:17:54 UTC

ping?

Comment 8 Parag AN(पराग) 2009-07-23 06:20:17 UTC

ping?

Comment 9 Parag AN(पराग) 2009-10-08 10:10:29 UTC

Its enough wait from submitter (as he said he will close this) now.

CLOSED.