Red Hat Bugzilla – Bug 507773
Review Request: python-daemon - Library to implement a well-behaved Unix daemon process
Last modified: 2009-10-08 06:10:29 EDT
Spec URL: http://kushal.fedorapeople.org/packages/python-daemon.spec
SRPM URL: http://kushal.fedorapeople.org/packages/python-daemon-1.4.6-1.fc11.src.rpm
Description: This library implements the well-behaved daemon specification of PEP 3143, "Standard daemon process library".
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1433003
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1433042
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
1) I don't get why you need version_info_fix.patch. Better do same in spec as
sed -i -e "s|#!/usr/bin/env python||" daemon/version/version_info.py
2) Should use %global instead %define
New Package CVS Request
Package Name: python-daemon
Short Description: Library to implement a well-behaved Unix daemon process
is this built for requested branches?
Its enough wait from submitter (as he said he will close this) now.