Bug 507801

Summary:	Review Request: perl-XML-Parser-Lite-Tree - Lightweight XML tree builder
Product:	[Fedora] Fedora	Reporter:	Michal Ingeli <mi>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lkundrak, notting, reidrac
Target Milestone:	---	Flags:	lkundrak: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.09-1.fc11	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-08-08 19:32:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	507805, 515045, 515046

Description Michal Ingeli 2009-06-24 11:00:50 UTC

Spec URL: http://v3.sk/~xyzz/rpm/f11/perl-XML-Parser-Lite-Tree.spec
SRPM URL: http://v3.sk/~xyzz/rpm/f11/perl-XML-Parser-Lite-Tree-0.08-1.fc11.src.rpm
Description: Simple XML tree builder. Dependency for flickr.com API module.

Comment 1 Lubomir Rintel 2009-06-26 12:58:26 UTC

1.) Licensing

README states "License: Perl Artistic License" (which sounds bad as it's not clear if GPL is permitted as well)m while XML::Parser::LiteCopy manual reads "This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself." (which is good). Please ask upstream for clarification.

2.) Please remove Require: perl(Test::More) dependency, the runtime does not depend on the testing framework.

Comment 2 Lubomir Rintel 2009-06-26 13:07:34 UTC

* name is well according to the guidelines
* source matches upstream
* clean and legible SPEC file, American English
* runs testsuite
* builds file in mock
* filelists, documentation ok

Needs work:
- sane provides/requires
- license ok

Comment 3 Lubomir Rintel 2009-06-26 13:07:54 UTC

* rpmlint is quiet

Comment 4 Michal Ingeli 2009-08-01 07:09:50 UTC

(In reply to comment #2)
> Needs work:
> - sane provides/requires
Fixed

> - license ok  
Corrected by upstream

Spec URL: http://v3.sk/~xyzz/rpm/f11/perl-XML-Parser-Lite-Tree.spec
SRPM URL: http://v3.sk/~xyzz/rpm/f11/perl-XML-Parser-Lite-Tree-0.09-1.fc11.src.rpm

Comment 5 Lubomir Rintel 2009-08-01 07:30:22 UTC

Perfect. Thanks!

APPROVED

Comment 6 Jason Tibbitts 2009-08-01 15:43:38 UTC

*** Bug 515044 has been marked as a duplicate of this bug. ***

Comment 7 Michal Ingeli 2009-08-01 20:41:26 UTC

New Package CVS Request
=======================
Package Name: perl-XML-Parser-Lite-Tree
Short Description: Lightweight XML tree builder
Owners: ksyz
Branches: F-11 EL-5
InitialCC:

Comment 8 Jason Tibbitts 2009-08-01 21:18:54 UTC

CVS done.

Comment 9 Fedora Update System 2009-08-06 21:16:55 UTC

perl-XML-Parser-Lite-Tree-0.09-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-XML-Parser-Lite-Tree-0.09-1.el5

Comment 10 Fedora Update System 2009-08-08 19:32:02 UTC

perl-XML-Parser-Lite-Tree-0.09-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-08-18 00:23:55 UTC

perl-XML-Parser-Lite-Tree-0.09-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.