Bug 507958

Thanks for the submission, Jeff.  A few comments:

- I think you're missing Requires on eclipse-cdt and eclipse-emf
- will we move to 3.1 once we get a Galileo CDT build?
- please use either %{buildroot} or $RPM_BUILD_ROOT but not both
- we should perhaps have Eclipse in the Summary field
- I think "framework" can be dropped from the Summary field
- please change the permissions on the fetch script to avoid this rpmlint warning:

eclipse-rse.src: W: strange-permission fetch-rse.sh 0775

- you should probably mark a top-level feature's about.html as %doc
- you should look for @build@ and replace it with the same qualifier that upstream uses.  In fact, you should use forceContextQualifier (see eclipse-mylyn.spec for an example) to ensure our versions are the same as upstream's for 3.0.3

The package builds for me, follows the packaging guidelines, and functions in Eclipse.  Thanks for the high quality submission.  Once the minor issues above are cleaned up, I will approve this.

(In reply to comment #1)
> Thanks for the submission, Jeff.  A few comments:
> 
> - I think you're missing Requires on eclipse-cdt and eclipse-emf

done

> - will we move to 3.1 once we get a Galileo CDT build?

Yes.  CDT 6.0 only requires RSE >= 3.0.

> - please use either %{buildroot} or $RPM_BUILD_ROOT but not both

done

> - we should perhaps have Eclipse in the Summary field

done

> - I think "framework" can be dropped from the Summary field

ok, done

> - please change the permissions on the fetch script to avoid this rpmlint
> warning:
> 
> eclipse-rse.src: W: strange-permission fetch-rse.sh 0775
> 

done

> - you should probably mark a top-level feature's about.html as %doc

done.  I get a warning about file being specified twice, but I don't see any other examples in any of the other eclipse projects.

> - you should look for @build@ and replace it with the same qualifier that
> upstream uses.  In fact, you should use forceContextQualifier (see
> eclipse-mylyn.spec for an example) to ensure our versions are the same as
> upstream's for 3.0.3
> 

I can't use forceContextQualifier because the versions are being set by map files.  The RSE project has many version qualifiers for the various plugins and features.  It does not create a single build id for a release and none of the qualifiers are filled in for the various tags.  I have fixed this by using the map files to a) fetch the plugins/features for the tarball b) create a featureVersions.properties and pluginVersions.properties file from the same map files.  Both a and b are performed in the fetch-rse.sh script.  The build now matches the upstream version numbers, including the suffixes which are used for features.  I have opened an RFE for pdebuild to allow map files to be specified which should make this easier for future rpm packaging.

> The package builds for me, follows the packaging guidelines, and functions in
> Eclipse.  Thanks for the high quality submission.  Once the minor issues above
> are cleaned up, I will approve this.  

Thanks.

I forgot to mention that I have overwritten the spec file and SRPM:

Spec URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse.spec
SRPM URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse-3.0.3-1.fc12.src.rpm

(In reply to comment #2)
> > - you should probably mark a top-level feature's about.html as %doc
> 
> done.  I get a warning about file being specified twice, but I don't see any
> other examples in any of the other eclipse projects.
> 
You can directly use paths as they are inside sources and this will prevent this warnings from showing, e.g.:
%doc org.eclipse.rse.sdk-feature/epl-v10.html
%doc org.eclipse.rse.sdk-feature/license.html

A few more minor things:

- you have ${_jvmdir} and %{_jvmdir}
- this is weird:  $RPM_BUILD_ROOT%{install_loc} ... please use %{buildroot}%{install_loc}.  In fact, please s/$RPM_BUILD_ROOT/%{buildroot}/g in the whole file
- do what Alex suggests for the doc files

Thanks for dealing with the qualifier situation.

(In reply to comment #5)
> A few more minor things:
> 
> - you have ${_jvmdir} and %{_jvmdir}

fixed to use %{_jvmdir}

> - this is weird:  $RPM_BUILD_ROOT%{install_loc} ... please use
> %{buildroot}%{install_loc}.  In fact, please s/$RPM_BUILD_ROOT/%{buildroot}/g
> in the whole file

done

> - do what Alex suggests for the doc files
> 

done

> Thanks for dealing with the qualifier situation.  

Replaced files at:

Spec URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse.spec
SRPM URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse-3.0.3-1.fc12.src.rpm

Thanks.  This submission is approved.

New Package CVS Request
=======================
Package Name: eclipse-rse
Short Description: Eclipse Remote System Explorer
Owners: jjohnstn
Branches: 
InitialCC: jjohnstn

CVS done.

eclipse-rse-3.0.3-1.fc12 successfully built

*** Bug 252223 has been marked as a duplicate of this bug. ***