Bug 508510
| Summary: | Review Request: python-Scriptaculous - Scriptaculous packaged as TurboGears widgets. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Itamar Reis Peixoto <itamar> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.8.2-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-16 06:54:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 508511 | ||
|
Description
Itamar Reis Peixoto
2009-06-28 04:25:44 UTC
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1439466 + rpmlint output for SRPM and for RPM. python-Scriptaculous.noarch: E: zero-length /usr/lib/python2.6/site-packages/Scriptaculous-1.8.2-py2.6.egg-info/not-zip-safe ==> can be ignored I guess as these are zero length files. + source files match upstream url f01e40103607f5255e624e216c2bd1d52e86435a Scriptaculous-1.8.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Sugeestions: 1) Source URL should be http://pypi.python.org/packages/source/L/Scriptaculous/Scriptaculous-%{version}.tar.gz 2) %doc should be %doc README.txt PKG-INFO 3) Why there is some comments related to LICENSE file? Remove that. 4) Change %define to %global ping? pong please hold, I will do this today. fixed. http://ispbrasil.com.br/python-Scriptaculous/python-Scriptaculous.spec http://ispbrasil.com.br/python-Scriptaculous/python-Scriptaculous-1.8.2-2.fc11.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1457322 APPROVED. New Package CVS Request ======================= Package Name: python-Scriptaculous Short Description: Scriptaculous packaged as TurboGears widgets Owners: itamarjp Branches: F-10 F-11 EL-5 InitialCC: CVS done. python-Scriptaculous-1.8.2-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-Scriptaculous-1.8.2-2.fc11 python-Scriptaculous-1.8.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-Scriptaculous-1.8.2-2.fc10 python-Scriptaculous-1.8.2-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-Scriptaculous-1.8.2-2.el5 python-Scriptaculous-1.8.2-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-Scriptaculous'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0043 python-Scriptaculous-1.8.2-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. python-Scriptaculous-1.8.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. python-Scriptaculous-1.8.2-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |