Spec URL: http://ispbrasil.com.br/python-Lightbox/python-Lightbox.spec SRPM URL: http://ispbrasil.com.br/python-Lightbox/python-Lightbox-2.1-1.fc11.src.rpm Description: Lightbox photo display widget more info in http://docs.turbogears.org/tgLightbox koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1439471
Why %dir %{python_sitelib}/lightbox %{python_sitelib}/lightbox/* instead of just %{python_sitelib}/lightbox/ ?
fixed. http://ispbrasil.com.br/python-Lightbox/python-Lightbox.spec http://ispbrasil.com.br/python-Lightbox/python-Lightbox-2.1-1.fc11.src.rpm
I am waiting for dependency python-Scriptaculous to be built in rawhide and available for this review.
I will review this soon. Sorry for delay. Got busy with other work.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1481057 + rpmlint output on SRPM and for RPM. python-Lightbox.src: E: description-line-too-long Lightbox is a TurboGears widget wrapper for the Lightbox2 JavaScript library by Lokesh Dhakar. python-Lightbox.src: E: description-line-too-long It displays a thumbnail image which, when clicked, opens an overlay popup window for viewing python-Lightbox.src: E: description-line-too-long the linked image in full size. You can also browse through several Lightbox images that are python-Lightbox.noarch: E: description-line-too-long Lightbox is a TurboGears widget wrapper for the Lightbox2 JavaScript library by Lokesh Dhakar. python-Lightbox.noarch: E: description-line-too-long It displays a thumbnail image which, when clicked, opens an overlay popup window for viewing python-Lightbox.noarch: E: description-line-too-long the linked image in full size. You can also browse through several Lightbox images that are python-Lightbox.noarch: E: script-without-shebang /usr/lib/python2.6/site-packages/lightbox/static/css/lightbox.css python-Lightbox.noarch: E: script-without-shebang /usr/lib/python2.6/site-packages/lightbox/static/javascript/lightbox.js + source files match upstream url 82d970d81261efa020071e4507a284aeb866e5d7 Lightbox-2.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + %doc is present. + BuildRequires are proper. + %clean is present. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Provide updated SRPM which will fix also comment #1 Fix rpmlint messages
do you know the right permission to fix this ? python-Lightbox.noarch: E: script-without-shebang /usr/lib/python2.6/site-packages/lightbox/static/javascript/lightbox.js
look if sounds good now. http://ispbrasil.com.br/python-Lightbox/python-Lightbox.spec http://ispbrasil.com.br/python-Lightbox/python-Lightbox-2.1-2.fc11.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1482755
If you want to use macros then use all macros in spec. Use macro %{__rm} for rm command also. APPROVED.
New Package CVS Request ======================= Package Name: python-Lightbox Short Description: Lightbox photo display widget Owners: itamarjp Branches: F-10 F-11 EL-5 InitialCC:
CVS done.
python-Lightbox-2.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-Lightbox-2.1-2.fc11
python-Lightbox-2.1-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-Lightbox-2.1-2.el5
python-Lightbox-2.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-Lightbox-2.1-2.fc10
spot, Can you please help here to identify correct license for this package. I actually got mail at https://www.redhat.com/archives/fedora-devel-list/2009-July/msg01557.html Thanks.
the JavaScript code comes from http://www.lokeshdhakar.com/projects/lightbox2/ "Can I use the script in a commercial project? Yes. It is licensed under the Creative Commons Attribution 2.5 License. A donation would be nice, hint hint." the python code is MIT and javascript code is Creative Commons Attribution 2.5
python-Lightbox-2.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
python-Lightbox-2.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Yes, the license tag should be "MIT and CC-BY", and I think FE-Legal blocker is not needed.
(In reply to comment #18) > Yes, the license tag should be "MIT and CC-BY", and I think > FE-Legal blocker is not needed. thanks, I have fixed
python-Lightbox-2.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.