Bug 508521
| Summary: | Review Request: jettison - A JSON StAX implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sandro Mathys <sandro> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lkundrak, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | F13FeatureIDEA | ||
| Fixed In Version: | 1.1-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-23 16:54:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sandro Mathys
2009-06-28 10:40:08 UTC
Good, work; nice and clean!
1.) I suggest you use a %{version} macro here, to ease updates:
jar -cf jettison-1.1.jar -C target .
Full review:
* spec file legible, uses american english
* source matches upstream
* packages latest version
* rpmlint silent
* builds fine in mock (scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1780920)
* license ok, listed in %doc
* javadoc built, conforming to guidelines
* no prebuilt stuff
* filelists sane
* macros used consistently
APPROVED
Hi Lubomir, thanks for the review :) Glad to see there's nothing to complain about :) will replace jettison-1.1 with %{name}-%{version} in the mentioned line before I push the pkg.
New Package CVS Request
=======================
Package Name: jettison
Short Description: A JSON StAX implementation
Owners: red
Branches: F-11 F-12 EL-4 EL-5
InitialCC:
cvs done. jettison-1.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jettison-1.1-1.fc11 jettison-1.1-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/jettison-1.1-1.el5 Building for EL-4 didn't work (probably a problem with the Java version) and F-12 currently doesn't accept updates except through requesting manual tagging. Will update this as the one or the other gets fixed. jettison-1.1-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jettison'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10967 jettison-1.1-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jettison'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0793 jettison-1.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. jettison-1.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Won't build an EL-4 version due to lack of interest in maintaining it with java 1.5 (i.e. gcj). If someone else in the future wants to co-maintain this for EL-4 feel free to contact me. |