Bug 508521 - Review Request: jettison - A JSON StAX implementation
Summary: Review Request: jettison - A JSON StAX implementation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: F13FeatureIDEA
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-28 10:40 UTC by Sandro Mathys
Modified: 2009-12-09 15:43 UTC (History)
3 users (show)

Fixed In Version: 1.1-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-23 16:54:55 UTC
lkundrak: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Sandro Mathys 2009-06-28 10:40:08 UTC
Spec URL: http://red.fedorapeople.org/SRPMS/jettison.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/jettison-1.1-1.fc11.src.rpm
Description:
Jettison is a collection of Java APIs (like STaX and DOM) which read
and write JSON. This allows nearly transparent enablement of JSON based
web services in services frameworks like CXF or XML serialization

rpmlint on spec, srpm and noarch-rpms finishes checking without any warnings or
errors.

Comment 1 Lubomir Rintel 2009-11-01 10:30:23 UTC
Good, work; nice and clean!

1.) I suggest you use a %{version} macro here, to ease updates:
jar -cf jettison-1.1.jar -C target .

Full review:

* spec file legible, uses american english
* source matches upstream
* packages latest version
* rpmlint silent
* builds fine in mock (scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1780920)
* license ok, listed in %doc
* javadoc built, conforming to guidelines
* no prebuilt stuff
* filelists sane
* macros used consistently

APPROVED

Comment 2 Sandro Mathys 2009-11-02 07:59:13 UTC
Hi Lubomir, thanks for the review :) Glad to see there's nothing to complain about :) will replace jettison-1.1 with %{name}-%{version} in the mentioned line before I push the pkg.


New Package CVS Request
=======================
Package Name: jettison
Short Description: A JSON StAX implementation
Owners: red
Branches: F-11 F-12 EL-4 EL-5
InitialCC:

Comment 3 Kevin Fenzi 2009-11-03 04:34:41 UTC
cvs done.

Comment 4 Fedora Update System 2009-11-03 07:26:55 UTC
jettison-1.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/jettison-1.1-1.fc11

Comment 5 Fedora Update System 2009-11-03 07:27:57 UTC
jettison-1.1-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/jettison-1.1-1.el5

Comment 6 Sandro Mathys 2009-11-03 07:32:08 UTC
Building for EL-4 didn't work (probably a problem with the Java version) and F-12 currently doesn't accept updates except through requesting manual tagging.

Will update this as the one or the other gets fixed.

Comment 7 Fedora Update System 2009-11-04 12:24:32 UTC
jettison-1.1-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jettison'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10967

Comment 8 Fedora Update System 2009-11-05 21:27:04 UTC
jettison-1.1-1.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jettison'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0793

Comment 9 Fedora Update System 2009-11-23 16:54:49 UTC
jettison-1.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-11-24 08:00:04 UTC
jettison-1.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Sandro Mathys 2009-12-09 15:43:53 UTC
Won't build an EL-4 version due to lack of interest in maintaining it with java 1.5 (i.e. gcj). If someone else in the future wants to co-maintain this for EL-4 feel free to contact me.


Note You need to log in before you can comment on or make changes to this bug.