Bug 508693
| Summary: | Review Request: perl-CGI-Application-Plugin-ConfigAuto - Easy config file management for CGI::Application | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.30-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-16 07:34:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Emmanuel Seyman
2009-06-29 14:14:55 UTC
can you put correct SRPM URL please? (In reply to comment #1) > can you put correct SRPM URL please? /me signs. Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ConfigAuto/perl-CGI-Application-Plugin-ConfigAuto.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ConfigAuto/perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11.src.rpm Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1446011 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1527cac938bc9730a30a91c03bae68715866e6dc CGI-Application-Plugin-ConfigAuto-1.30.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=11, 1 wallclock secs ( 0.04 usr 0.02 sys + 0.23 cusr 0.04 csys = 0.33 CPU) + Package perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc12.noarch => Provides: perl(CGI::Application::Plugin::ConfigAuto) = 1.30 Requires: perl(Carp) perl(Exporter) perl(strict) perl(vars) + Not a GUI application APPROVED. (In reply to comment #3) > > APPROVED. Thanks! Requesting CVS. New Package CVS Request ======================= Package Name: perl-CGI-Application-Plugin-ConfigAuto Short Description: Easy config file management for CGI::Application Owners: eseyman Branches: F-11 F-10 InitialCC: perl-sig cvs done. perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-ConfigAuto'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7363 perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |