Bug 508693 - Review Request: perl-CGI-Application-Plugin-ConfigAuto - Easy config file management for CGI::Application
Summary: Review Request: perl-CGI-Application-Plugin-ConfigAuto - Easy config file man...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-29 14:14 UTC by Emmanuel Seyman
Modified: 2009-07-16 07:34 UTC (History)
3 users (show)

Fixed In Version: 1.30-1.fc11
Clone Of:
Environment:
Last Closed: 2009-07-16 07:34:13 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2009-06-29 14:14:55 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ConfigAuto/perl-CGI-Application-Plugin-ConfigAuto.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ConfigAuto/perl-CGI-Application-Plugin-ConfigAuto.spec
Description:
CGI::Application::Plugin::ConfigAuto adds easy access to config file
variables to your CGI::Application modules. Lazy loading is used to prevent
the config file from being parsed if no configuration variables are
accessed during the request.

Comment 1 Parag AN(पराग) 2009-06-30 09:07:14 UTC
can you put correct SRPM URL please?

Comment 3 Parag AN(पराग) 2009-07-01 06:00:45 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1446011
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
1527cac938bc9730a30a91c03bae68715866e6dc  CGI-Application-Plugin-ConfigAuto-1.30.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=11,  1 wallclock secs ( 0.04 usr  0.02 sys +  0.23 cusr  0.04 csys =  0.33 CPU)
+ Package perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::ConfigAuto) = 1.30
Requires: perl(Carp) perl(Exporter) perl(strict) perl(vars)
+ Not a GUI application

APPROVED.

Comment 4 Emmanuel Seyman 2009-07-01 22:51:54 UTC
(In reply to comment #3)
>
> APPROVED.

Thanks! Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-CGI-Application-Plugin-ConfigAuto
Short Description: Easy config file management for CGI::Application
Owners: eseyman
Branches: F-11 F-10
InitialCC: perl-sig

Comment 5 Kevin Fenzi 2009-07-02 05:05:56 UTC
cvs done.

Comment 6 Fedora Update System 2009-07-02 08:07:18 UTC
perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11

Comment 7 Fedora Update System 2009-07-03 19:45:43 UTC
perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-ConfigAuto'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7363

Comment 8 Fedora Update System 2009-07-16 07:34:07 UTC
perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.