Bug 508849

Summary:	Review Request: perl-POE-Component-Server-Bayeux - Bayeux/cometd server implementation in POE
Product:	[Fedora] Fedora	Reporter:	Yanko Kaneti <yaneti>
Component:	Package Review	Assignee:	Jochen Schmitt <jochen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, jochen, notting
Target Milestone:	---	Flags:	jochen: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-07-01 05:39:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yanko Kaneti 2009-06-30 08:58:16 UTC

Spec URL: http://declera.com/~yaneti/perl-POE-Component-Server-Bayeux/perl-POE-Component-Server-Bayeux.spec
SRPM URL: http://declera.com/~yaneti/perl-POE-Component-Server-Bayeux/perl-POE-Component-Server-Bayeux-0.02-1.fc12.src.rpm
Description:
This module implements the Bayeux Protocol (1.0draft1) from the Dojo
Foundation. Also called cometd, Bayeux is a low-latency routing protocol
for JSON encoded events between clients and servers in a publish-
subscribe model.


$ rpmlint mock/fedora-rawhide-x86_64/result/perl-POE-Component-Server-Bayeux-0.02-1.fc12.*.rpm mock/fedora-10-i386/result/perl-POE-Component-Server-Bayeux-0.02-1.fc10.*.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jochen Schmitt 2009-06-30 19:26:52 UTC

Good:
+ Basename of SPEC files matches with package name
+ Package name fullfill naming guidelines
+ URL tag shows on proper project homepage
+ Could download upstream sources via spectool -g
+ Package source tar ball matches with upstream
(md5sum: dd18ab3f61f390fbc96a8dc8a15aa447)
* Package has proper License tag
+ License Tag says GPLv2 and Artistic as OSS license
* Copyright note in the source files matches with license tag
+ Package has proper Buildroot definition
+ Consistently usage of rpm macros
+ Proper Buildroot definition
+ BuidRoot will be clean at the beginning of %clean and %install
+ Package will be built for noarch
* Local build works fine
+ Package has a %check stanza
+ Rpmlint is quite for source rpm
+ rpmlint is quite for binary rpm
+ Scratch build on koji works fine
+ Local install and uninstall works fine
+ %doc stanza is small, no extra subpackage in required
+ Files has proper files permission
+ %files contains no duplicated entries
+ All packaged files are owned by this package
+ No packaged files belong to another package
+ package has proper Changelog


Bad:
- Package doesn't contains verbain copy of the license (no blocker)



** APPROVED **

Comment 2 Yanko Kaneti 2009-06-30 21:18:20 UTC

New Package CVS Request
=======================
Package Name: perl-POE-Component-Server-Bayeux
Short Description: Bayeux/cometd server implementation in POE
Owners: yaneti
Branches: F-10 F-11
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2009-07-01 02:44:17 UTC

CVS done.

Comment 4 Yanko Kaneti 2009-07-01 05:39:22 UTC

Imported. Builds done. Bodhi updates pending.
Thanks for the review.