Bug 508850
| Summary: | Review Request: hunspell-et - Estonian hunspell dictionaries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-01 07:44:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 508031 | ||
|
Description
Caolan McNamara
2009-06-30 09:01:11 UTC
Some years ago I accidentially imported the Estonian dictionaries as hunspell-ee but ee is the language code for Ewe, so I'd like to fix this up and re-import this dictionary as hunspell-et and remove hunspell-ee as a dead.package to leave it free for a future Ewe hunspell-ee. So the above hunspell-et.spec Obsoletes/Provides the last version of hunspell-ee in Fedora on upgrade. yes hunspell-et looks ok now for Estonian dictionaries. Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1443524 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a633ab90e5e37981360143b5ee2b63bc62c4e0df ispell-et_20030606.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: hunspell-et Short Description: Estonian hunspell dictionaries Owners: caolanm Branches: devel InitialCC: CVS done. |