Bug 508850 - Review Request: hunspell-et - Estonian hunspell dictionaries
Summary: Review Request: hunspell-et - Estonian hunspell dictionaries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 508031
TreeView+ depends on / blocked
 
Reported: 2009-06-30 09:01 UTC by Caolan McNamara
Modified: 2009-07-01 07:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-07-01 07:44:43 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2009-06-30 09:01:11 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-et.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-et-0.20030606-4.fc11.src.rpm
Description: Estonian hunspell dictionaries

Comment 1 Caolan McNamara 2009-06-30 09:04:37 UTC
Some years ago I accidentially imported the Estonian dictionaries as hunspell-ee but ee is the language code for Ewe, so I'd like to fix this up and re-import this dictionary as hunspell-et and remove hunspell-ee as a dead.package to leave it free for a future Ewe hunspell-ee. So the above hunspell-et.spec Obsoletes/Provides the last version of hunspell-ee in Fedora on upgrade.

Comment 2 Parag AN(पराग) 2009-06-30 09:10:29 UTC
yes hunspell-et looks ok now for Estonian dictionaries.

Comment 3 Parag AN(पराग) 2009-06-30 09:42:35 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1443524
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a633ab90e5e37981360143b5ee2b63bc62c4e0df  ispell-et_20030606.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 4 Caolan McNamara 2009-06-30 09:57:27 UTC
New Package CVS Request
=======================
Package Name: hunspell-et
Short Description: Estonian hunspell dictionaries
Owners: caolanm
Branches: devel
InitialCC:

Comment 5 Jason Tibbitts 2009-07-01 02:38:41 UTC
CVS done.


Note You need to log in before you can comment on or make changes to this bug.