Bug 508850 - Review Request: hunspell-et - Estonian hunspell dictionaries
Review Request: hunspell-et - Estonian hunspell dictionaries
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 508031
  Show dependency treegraph
 
Reported: 2009-06-30 05:01 EDT by Caolan McNamara
Modified: 2009-07-01 03:44 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-07-01 03:44:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Caolan McNamara 2009-06-30 05:01:11 EDT
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-et.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-et-0.20030606-4.fc11.src.rpm
Description: Estonian hunspell dictionaries
Comment 1 Caolan McNamara 2009-06-30 05:04:37 EDT
Some years ago I accidentially imported the Estonian dictionaries as hunspell-ee but ee is the language code for Ewe, so I'd like to fix this up and re-import this dictionary as hunspell-et and remove hunspell-ee as a dead.package to leave it free for a future Ewe hunspell-ee. So the above hunspell-et.spec Obsoletes/Provides the last version of hunspell-ee in Fedora on upgrade.
Comment 2 Parag AN(पराग) 2009-06-30 05:10:29 EDT
yes hunspell-et looks ok now for Estonian dictionaries.
Comment 3 Parag AN(पराग) 2009-06-30 05:42:35 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1443524
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a633ab90e5e37981360143b5ee2b63bc62c4e0df  ispell-et_20030606.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.
Comment 4 Caolan McNamara 2009-06-30 05:57:27 EDT
New Package CVS Request
=======================
Package Name: hunspell-et
Short Description: Estonian hunspell dictionaries
Owners: caolanm
Branches: devel
InitialCC:
Comment 5 Jason Tibbitts 2009-06-30 22:38:41 EDT
CVS done.

Note You need to log in before you can comment on or make changes to this bug.