Bug 508904

Summary: S-c-tools cleanup: Bad unit labels.
Product: [Fedora] Fedora Reporter: Roman Rakus <rrakus>
Component: system-config-lvmAssignee: Marek Grac <mgrac>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: agk, dwysocha, jreznik, mbroz, mclasen, prockai, tsmetana
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: system-config-lvm-1_1_8-1_fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-20 12:35:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 493605    
Attachments:
Description Flags
Proposed patch none

Description Roman Rakus 2009-06-30 13:24:09 UTC
Description of problem:
There are bad unit labels in Context info view on the right side.
Also no spaces.

How reproducible: 

Steps to Reproduce:
1. 
2. 
3. 

Actual results:
32.00M
55.69G
And so on

Expected results:
32.00 MB
55.69 GB

spaces between numbers and units
right units

Additional info:
This bug report is part of "System Configuration Tools Cleanup Project". Don't
hesitate to ask project maintainers for any kind of help.

Comment 1 Marek Grac 2009-08-20 12:03:23 UTC
Created attachment 358074 [details]
Proposed patch

This can be fixed only when info about logical volume is shown (2MB -> 2 MB).

In other cases information which are shown on the right are parsed from *display commands. This output is just split to label + value, we don't possess information which values are size of pv/vg so it cannot be replaced with more human-like values (1.00T is correct name of vg). This will be fixed automatically when tools from lvm2 will change their output (as they are not used anywhere else). Changing their output will broke existing scripts, so it option is dead also. 

Partially done (lv), partially won't fix (vg+pv).