Bug 508904 - S-c-tools cleanup: Bad unit labels.
Summary: S-c-tools cleanup: Bad unit labels.
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-lvm
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Marek Grac
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 493605
TreeView+ depends on / blocked
 
Reported: 2009-06-30 13:24 UTC by Roman Rakus
Modified: 2014-01-13 00:09 UTC (History)
7 users (show)

Fixed In Version: system-config-lvm-1_1_8-1_fc12
Clone Of:
Environment:
Last Closed: 2009-08-20 12:35:33 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Proposed patch (595 bytes, patch)
2009-08-20 12:03 UTC, Marek Grac
no flags Details | Diff

Description Roman Rakus 2009-06-30 13:24:09 UTC
Description of problem:
There are bad unit labels in Context info view on the right side.
Also no spaces.

How reproducible: 

Steps to Reproduce:
1. 
2. 
3. 

Actual results:
32.00M
55.69G
And so on

Expected results:
32.00 MB
55.69 GB

spaces between numbers and units
right units

Additional info:
This bug report is part of "System Configuration Tools Cleanup Project". Don't
hesitate to ask project maintainers for any kind of help.

Comment 1 Marek Grac 2009-08-20 12:03:23 UTC
Created attachment 358074 [details]
Proposed patch

This can be fixed only when info about logical volume is shown (2MB -> 2 MB).

In other cases information which are shown on the right are parsed from *display commands. This output is just split to label + value, we don't possess information which values are size of pv/vg so it cannot be replaced with more human-like values (1.00T is correct name of vg). This will be fixed automatically when tools from lvm2 will change their output (as they are not used anywhere else). Changing their output will broke existing scripts, so it option is dead also. 

Partially done (lv), partially won't fix (vg+pv).


Note You need to log in before you can comment on or make changes to this bug.