Bug 510321

This looks like http://dev.laptop.org/git/users/dsd/olpc-library/ except I only see 2.0.0 there, not 2.0.1. You need an upstream URL for Source0 or instructions on how to reproduce the tarball.

License needs "and BSD" added to be valid. But the file which causes that, namely "js/home-yahoo-dom-event.js", is copied from yui_xxx.zip from http://developer.yahoo.com/yui/ which should really be packaged separately.

Thanks!

http://dev.laptop.org/~dsd/20090709/olpc-library-2.0.2-1.fc11.src.rpm
http://dev.laptop.org/~dsd/20090709/olpc-library.spec

Source URL is now http://dev.laptop.org/~dsd/olpc-library/ and I removed that BSD file.

Is there a reason, why 'parallel make' is not used?
  https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make

No. Updated the spec file at http://dev.laptop.org/~dsd/20090709/olpc-library.spec

I downloaded the srpm but it doesn't look like any change was made to the spec there.  I know that was a trivial change, but please do bump the release and submit a new src.rpm when you make changes.

Could you indicate which files are under which license?  https://fedoraproject.org/wiki/Packaging:LicensingGuidelines has information on doing that.

Your Source0: URL is 404 for me.

Everything else looks good, but I've no experience at all with Sugar stuff so I may not be the best person to review this.  This doesn't seem to fall under the usual guidelines for Sugar activities so I'm not sure if there are any additional strictures I should consider.

Thanks, fixed all that.
http://dev.laptop.org/~dsd/20090711/olpc-library.spec
http://dev.laptop.org/~dsd/20090711/olpc-library-2.0.2-1.fc11.src.rpm

Indeed, it is not an activity. You can look at it as an independent program which parses the contents of certain directories and outputs an HTML file at a predetermined location. That's all :)

OK, that sounds simple enough.  Builds fine and rpmlint is silent; everything else seems fine.

* source files match upstream.  sha256sum:                 
  08d85b26501c37f5c0c3be420cddf5eb75559d2327b50e0383b33ec0bfb1b105
  olpc-library-2.0.2.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   olpc-library = 2.0.2-1.fc12
  =
   /usr/bin/env
   python-jinja
   sugar

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

New Package CVS Request
=======================
Package Name: olpc-library
Short Description: OLPC library page generator
Owners: dsd cjb pbrobinson
Branches: F-11
InitialCC:

CVS done.

olpc-library-2.0.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/olpc-library-2.0.2-1.fc11

Thanks Jason, much appreciated!

olpc-library-2.0.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.