Bug 510698
| Summary: | Review Request: klavaro - Typing tutor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bochecha, fedora-package-review, notting, panemade, tuju |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2.1-3.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-29 21:30:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-07-10 10:26:28 UTC
will pick this for review on Monday. http://sourceforge.net/tracker/?func=detail&aid=2819484&group_id=135657&atid=733522 was closed about permissions of /usr/bin/klavaro_helper. It seems that for now it's needed that setgid-binary is set to write to /var/games/klavaro for the scores. Here are the updated files Spec URL: http://fab.fedorapeople.org/packages/SRPMS/klavaro.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/klavaro-1.2.1-2.fc11.src.rpm Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1472652 - rpmlint is NOT silent for RPM. klavaro.i586: E: setgid-binary /usr/bin/klavaro_helper root 02755 The file is setgid. Usually this is a packaging bug. If this is a game, then, you should use the proper rpm group, or location. klavaro.i586: E: non-standard-executable-perm /usr/bin/klavaro_helper 02755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. + source files match upstream url b69ab99f94525902ca8d1f12fb46c041ad9cb5ba klavaro-1.2.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + gtk-update-icon-cache scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI application Should: 1) Correct license tag to GPLv3+ APPROVED. Thanks for the review, Parag. I will fix the license before the cvs import. New Package CVS Request ======================= Package Name: klavaro Short Description: Typing tutor Owners: fab Branches: F-10 F-11 InitialCC: *** Bug 511146 has been marked as a duplicate of this bug. *** CVS done. klavaro-1.2.1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/klavaro-1.2.1-3.fc10 klavaro-1.2.1-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/klavaro-1.2.1-3.fc11 klavaro-1.2.1-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update klavaro'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7702 klavaro-1.2.1-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update klavaro'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7711 klavaro-1.2.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. klavaro-1.2.1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |