Bug 511191

Summary: Review Request: yokadi - Command line oriented todo list system
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.10.0-2.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-29 21:28:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 511155    
Bug Blocks:    

Description Fabian Affolter 2009-07-14 06:07:58 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/yokadi.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/yokadi-0.10.0-1.fc11.src.rpm

Project URL: http://yokadi.github.com/

Description:
Yokadi is a command-line oriented, SQLite powered, TODO list tool.
It helps you organize all the things you have to do and you must not
forget.It aims to be simple, intuitive and very efficient.

In Yokadi you manage projects, which contains tasks. At the minimum,
a task has a title, but it can also have a description, a due date,
an urgency or keywords. Keywords can be any word that help you to find
and sort your tasks.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1472548

rpmlint output:
[fab@laptop09 SRPMS]$ rpmlint yokadi-0.10.0-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop09 noarch]$ rpmlint yokadi-0.10.0-1.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Parag AN(पराग) 2009-07-14 08:42:01 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1472743
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
80cd6f335d7149cb2ab552fcc16ce63a4f12e63d  yokadi-0.10.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Should:
1) make sure you follow new change in BR for python packages 
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

APPROVED.

Comment 2 Fabian Affolter 2009-07-14 11:39:06 UTC
Thanks for the review and the hint about the BR.

Comment 3 Fabian Affolter 2009-07-14 11:42:20 UTC
New Package CVS Request
=======================
Package Name: yokadi
Short Description: Command line oriented todo list system
Owners: fab
Branches: F-10 F-11
InitialCC:

Comment 4 Jason Tibbitts 2009-07-15 02:33:50 UTC
CVS done.

Comment 5 Fedora Update System 2009-07-15 20:41:48 UTC
yokadi-0.10.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/yokadi-0.10.0-2.fc10

Comment 6 Fedora Update System 2009-07-15 20:41:53 UTC
yokadi-0.10.0-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/yokadi-0.10.0-2.fc11

Comment 7 Fedora Update System 2009-07-19 10:17:13 UTC
yokadi-0.10.0-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update yokadi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7736

Comment 8 Fedora Update System 2009-07-19 10:18:13 UTC
yokadi-0.10.0-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update yokadi'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7740

Comment 9 Fedora Update System 2009-07-29 21:28:20 UTC
yokadi-0.10.0-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-07-29 21:36:20 UTC
yokadi-0.10.0-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.