Bug 511374
| Summary: | ExpressCards should be detected and useful | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Suzanne Hillman <shillman> | ||||||||||
| Component: | kernel | Assignee: | Pete Zaitcev <zaitcev> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | low | ||||||||||||
| Version: | 5.5 | CC: | jfeeney, martinez, peterm, zaitcev | ||||||||||
| Target Milestone: | rc | Keywords: | Desktop | ||||||||||
| Target Release: | 5.5 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2010-03-30 07:47:01 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Bug Depends On: | |||||||||||||
| Bug Blocks: | 533192, 557926 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Suzanne Hillman
2009-07-14 20:41:04 UTC
This happens on Lenovo Thinkpad R400, as well, with the addresses being different - unsurprisingly - but the rest of the behavior the same. Same ExpressCard. This is relevant to RHEL5.4. Due to the degree of not functional, moving to RHEL6.0. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. The -32 is STALL, which means that the device is functional (firmware did not crash), but it rejects our command. But rejecting the basic descriptor read is VERY unusual. The enumeration is rather well documented, tests exist, so device vendors rarely blow it these days. Suzanne, may I get a remote access to the system in question? I guess it must be your personal box since it's a laptop. I only need an hour at the most. BTW, does this hardware work anywhere, say in Windows? It's not actually my personal box; Desktop QE does laptop testing. It's currently available at 10.16.3.35. I am on IRC as shillman, and can give you the login info there (not really comfortable putting it in here). The card is in the machine right now. I do not know if it works in Windows, as I do not have a Windows box to test it with. However, it appears to work fine (gets mounted; nautilus shows it) in F11, kernel-2.6.29.5-191.fc11 Created attachment 357733 [details]
usbmon trace of fault, annotated
The usbmon trace from F11 makes it clear that the card takes its time processing descriptor reads after a reset: 1888e3c0 2.827968 C Ci:1:000:0 0 18 = 12010002 00000040 dc0500ea 00110102 0301 1888e3c0 2.828062 S Co:1:001:0 s 23 03 0004 0002 0000 0 <---- 1.951s turnaround time So, I think we're safe for RHEL 6, we just need to fix this in RHEL 5. I'm setting devel-ack to + because I've already done the development, so it's almost zero cost for us to fix (unless I create a regression by fixing this). Please test kernel 2.6.18-164.el5.bz511374.1 from here: http://people.redhat.com/zaitcev/ftp/511374/ Test kernel absolutely fixes the problem. Not clear to me if this is something of sufficient import to make it into a RHEL5 update release, and not clear to me how difficult it would be to tell if there is a regression. Created attachment 358655 [details]
Test patch 1
The fix is already tested, but I forgot to upload the patch that was tested,
so here we go.
I think the danger of regressions is very low. The fixed kernel merely
imitates what I saw in Fedora's usbmon trace that Mark captured. The only
failure scenario I envision is if some user-more program loses patience
(in particular SANE-based scanning is what I'd like to see working).
Created attachment 358656 [details]
usbmon trace of success, annotated
Sorry, here is Mark's trace that I used to make the patch.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Created attachment 377666 [details] Test patch 2 Patch updated with the feedback from Jarod Wilson. It should be _exactly_ the same, function-wise. But I rebuilt and uploaded the kernel in case, same location. Version 2.6.18-164.el5.bz511374.2. in kernel-2.6.18-181.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html |