Bug 511374 - ExpressCards should be detected and useful
Summary: ExpressCards should be detected and useful
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: 5.5
Assignee: Pete Zaitcev
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 533192 557926
TreeView+ depends on / blocked
 
Reported: 2009-07-14 20:41 UTC by Suzanne Hillman
Modified: 2010-03-30 07:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:47:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
usbmon trace of fault, annotated (5.21 KB, text/plain)
2009-08-18 04:36 UTC, Pete Zaitcev
no flags Details
Test patch 1 (633 bytes, patch)
2009-08-26 01:35 UTC, Pete Zaitcev
no flags Details | Diff
usbmon trace of success, annotated (235.12 KB, text/plain)
2009-08-26 01:36 UTC, Pete Zaitcev
no flags Details
Test patch 2 (1.96 KB, application/octet-stream)
2009-12-11 04:22 UTC, Pete Zaitcev
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Suzanne Hillman 2009-07-14 20:41:04 UTC
Description of problem:
Dell M4300 cannot correctly detect an ExpressCard, as it fails to be able to get to the point where hal can mount it.

Version-Release number of selected component (if applicable):
2.16.18-157.el5

How reproducible:
Always

Steps to Reproduce:
1. Install 20090708 x86_64 tree on Dell M4300
2. Log into gnome, and tail -f /var/log/messages
3. Insert Lexar 16GB ExpressCard SSD card.
  
Actual results:

In /var/log/messages:

Jul 14 20:39:10 dell-m4300-01 kernel: usb 1-1: new high speed USB device using ehci_hcd and address 22
Jul 14 20:39:12 dell-m4300-01 kernel: usb 1-1: device descriptor read/64, error -32
Jul 14 20:39:12 dell-m4300-01 kernel: usb 1-1: device descriptor read/64, error -32
Jul 14 20:39:12 dell-m4300-01 kernel: usb 1-1: new high speed USB device using ehci_hcd and address 23
Jul 14 20:39:12 dell-m4300-01 kernel: usb 1-1: device descriptor read/64, error -32
Jul 14 20:39:12 dell-m4300-01 kernel: usb 1-1: device descriptor read/64, error -32
Jul 14 20:39:12 dell-m4300-01 kernel: usb 1-1: new high speed USB device using ehci_hcd and address 24
Jul 14 20:39:13 dell-m4300-01 kernel: usb 1-1: device not accepting address 24, error -32
Jul 14 20:39:13 dell-m4300-01 kernel: usb 1-1: new high speed USB device using ehci_hcd and address 25
Jul 14 20:39:13 dell-m4300-01 kernel: usb 1-1: device not accepting address 25, error -32


Expected results:
No errors in /var/log/messages, and should mount and display the contents of the card.

Additional info:
No clue if this is a regression. Checking with earlier tester.

Comment 1 Suzanne Hillman 2009-07-15 18:06:25 UTC
This happens on Lenovo Thinkpad R400, as well, with the addresses being different - unsurprisingly - but the rest of the behavior the same. Same ExpressCard.

Comment 2 Suzanne Hillman 2009-07-15 18:32:44 UTC
This is relevant to RHEL5.4. Due to the degree of not functional, moving to RHEL6.0.

Comment 3 RHEL Program Management 2009-07-15 18:38:04 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 4 RHEL Program Management 2009-07-15 18:58:10 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 5 Pete Zaitcev 2009-07-20 18:20:12 UTC
The -32 is STALL, which means that the device is functional (firmware
did not crash), but it rejects our command. But rejecting the basic
descriptor read is VERY unusual. The enumeration is rather well
documented, tests exist, so device vendors rarely blow it these days.

Suzanne, may I get a remote access to the system in question? I guess
it must be your personal box since it's a laptop. I only need an hour
at the most.

BTW, does this hardware work anywhere, say in Windows?

Comment 6 Suzanne Hillman 2009-07-22 14:06:46 UTC
It's not actually my personal box; Desktop QE does laptop testing.

It's currently available at 10.16.3.35. I am on IRC as shillman, and can give you the login info there (not really comfortable putting it in here). The card is in the machine right now.

I do not know if it works in Windows, as I do not have a Windows box to test it with. However, it appears to work fine (gets mounted; nautilus shows it) in F11, kernel-2.6.29.5-191.fc11

Comment 7 Pete Zaitcev 2009-08-18 04:36:49 UTC
Created attachment 357733 [details]
usbmon trace of fault, annotated

Comment 8 Pete Zaitcev 2009-08-22 02:51:42 UTC
The usbmon trace from F11 makes it clear that the card takes its time
processing descriptor reads after a reset:

1888e3c0 2.827968 C Ci:1:000:0 0 18 = 12010002 00000040 dc0500ea 00110102 0301
1888e3c0 2.828062 S Co:1:001:0 s 23 03 0004 0002 0000 0
 <---- 1.951s turnaround time

So, I think we're safe for RHEL 6, we just need to fix this in RHEL 5.

Comment 9 Pete Zaitcev 2009-08-22 02:53:52 UTC
I'm setting devel-ack to + because I've already done the development,
so it's almost zero cost for us to fix (unless I create a regression
by fixing this).

Comment 10 Pete Zaitcev 2009-08-22 10:08:10 UTC
Please test kernel 2.6.18-164.el5.bz511374.1 from here:
 http://people.redhat.com/zaitcev/ftp/511374/

Comment 11 Suzanne Hillman 2009-08-25 17:55:21 UTC
Test kernel absolutely fixes the problem. Not clear to me if this is something of sufficient import to make it into a RHEL5 update release, and not clear to me how difficult it would be to tell if there is a regression.

Comment 12 Pete Zaitcev 2009-08-26 01:35:41 UTC
Created attachment 358655 [details]
Test patch 1

The fix is already tested, but I forgot to upload the patch that was tested,
so here we go.

I think the danger of regressions is very low. The fixed kernel merely
imitates what I saw in Fedora's usbmon trace that Mark captured. The only
failure scenario I envision is if some user-more program loses patience
(in particular SANE-based scanning is what I'd like to see working).

Comment 13 Pete Zaitcev 2009-08-26 01:36:58 UTC
Created attachment 358656 [details]
usbmon trace of success, annotated

Sorry, here is Mark's trace that I used to make the patch.

Comment 14 RHEL Program Management 2009-09-25 17:41:09 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 15 Pete Zaitcev 2009-12-11 04:22:21 UTC
Created attachment 377666 [details]
Test patch 2

Patch updated with the feedback from Jarod Wilson. It should be _exactly_
the same, function-wise. But I rebuilt and uploaded the kernel in case,
same location. Version 2.6.18-164.el5.bz511374.2.

Comment 16 Don Zickus 2009-12-15 20:17:50 UTC
in kernel-2.6.18-181.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 19 errata-xmlrpc 2010-03-30 07:47:01 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.